From: Johan Hovold <johan@kernel.org>
To: Octavian Purdila <octavian.purdila@intel.com>
Cc: sameo@linux.intel.com, lee.jones@linaro.org,
linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org,
johan@kernel.org
Subject: Re: [PATCH v4 3/3] mfd: viperboard: remove unused platform_device
Date: Thu, 25 Sep 2014 17:54:08 +0200 [thread overview]
Message-ID: <20140925155408.GL32124@localhost> (raw)
In-Reply-To: <1411659697-27258-4-git-send-email-octavian.purdila@intel.com>
On Thu, Sep 25, 2014 at 06:41:37PM +0300, Octavian Purdila wrote:
> Remove pdev field from struct vpbrd as it is not used in the MFD
> driver or in any of the sub-drivers.
>
> Signed-off-by: Octavian Purdila <octavian.purdila@intel.com>
Reviewed-by: Johan Hovold <johan@kernel.org>
> ---
> drivers/mfd/viperboard.c | 1 -
> include/linux/mfd/viperboard.h | 1 -
> 2 files changed, 2 deletions(-)
>
> diff --git a/drivers/mfd/viperboard.c b/drivers/mfd/viperboard.c
> index 0d46d05..f4dcba6 100644
> --- a/drivers/mfd/viperboard.c
> +++ b/drivers/mfd/viperboard.c
> @@ -73,7 +73,6 @@ static int vprbrd_probe(struct usb_interface *interface,
>
> /* save our data pointer in this interface device */
> usb_set_intfdata(interface, vb);
> - dev_set_drvdata(&vb->pdev.dev, vb);
>
> /* get version information, major first, minor then */
> pipe = usb_rcvctrlpipe(vb->usb_dev, 0);
> diff --git a/include/linux/mfd/viperboard.h b/include/linux/mfd/viperboard.h
> index af928d0..afc14ed 100644
> --- a/include/linux/mfd/viperboard.h
> +++ b/include/linux/mfd/viperboard.h
> @@ -104,7 +104,6 @@ struct vprbrd {
> struct usb_device *usb_dev; /* the usb device for this device */
> struct mutex lock;
> u8 *buf;
> - struct platform_device pdev;
> };
>
> #endif /* __MFD_VIPERBOARD_H__ */
next prev parent reply other threads:[~2014-09-25 15:56 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-25 15:41 [PATCH v4 0/3] mfd: viperboard: fix cache line sharing and cleanups Octavian Purdila
2014-09-25 15:41 ` [PATCH v4 1/3] mfd: viperboard: allocate I/O buffer separately Octavian Purdila
2014-09-25 15:52 ` Johan Hovold
2014-09-25 15:41 ` [PATCH v4 2/3] mfd: viperboard: switch to devm_ allocation Octavian Purdila
2014-09-25 15:53 ` Johan Hovold
2014-09-25 15:41 ` [PATCH v4 3/3] mfd: viperboard: remove unused platform_device Octavian Purdila
2014-09-25 15:54 ` Johan Hovold [this message]
2014-10-09 20:39 ` [PATCH v4 0/3] mfd: viperboard: fix cache line sharing and cleanups Octavian Purdila
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140925155408.GL32124@localhost \
--to=johan@kernel.org \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=octavian.purdila@intel.com \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.