Re: [nft PATCH 3/3 v2] src: add list ruleset command

[Pablo Neira Ayuso <pablo@netfilter.org>]

On Wed, Sep 24, 2014 at 04:54:10PM +0200, Arturo Borrero Gonzalez wrote:
> On 24 September 2014 12:32, Arturo Borrero Gonzalez
> <arturo.borrero.glez@gmail.com> wrote:
> > This patch adds a new command to nft:
> >         % nft list ruleset [family]
> >
> 
> Hi,
> 
> this patch requires further review and tuning.
> 
> When using the interactive mode there are weird behaviours I need to
> investigate.
> Any pointer will be appreciated.

static LIST_HEAD(table_list);

void table_add_hash(struct table *table)
{
        list_add_tail(&table->list, &table_list);
}

+static int do_list_ruleset(struct netlink_ctx *ctx, struct cmd *cmd)
+{
+       struct table *table, *next;
+       LIST_HEAD(table_list);
        ^------------------^

I think we have to select a different name for this variable that is
allocated in the stack, since we already have a global table_list.