Re: [PATCH v6 for-4.5 2/5] xl: move 'replace_string' further up the file

[Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>]

On Wed, Sep 24, 2014 at 09:48:02PM +0100, David Scott wrote:
> This allows the function to be reused more easily.

Reviewed-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
> 
> Signed-off-by: David Scott <dave.scott@citrix.com>
> ---
>  tools/libxl/xl_cmdimpl.c |   13 ++++++-------
>  1 file changed, 6 insertions(+), 7 deletions(-)
> 
> diff --git a/tools/libxl/xl_cmdimpl.c b/tools/libxl/xl_cmdimpl.c
> index 698b3bc..1695f74 100644
> --- a/tools/libxl/xl_cmdimpl.c
> +++ b/tools/libxl/xl_cmdimpl.c
> @@ -799,6 +799,12 @@ static void parse_vcpu_affinity(libxl_domain_build_info *b_info,
>      }
>  }
>  
> +static void replace_string(char **str, const char *val)
> +{
> +    free(*str);
> +    *str = strdup(val);
> +}
> +
>  static void parse_config_data(const char *config_source,
>                                const char *config_data,
>                                int config_len,
> @@ -1914,13 +1920,6 @@ static int match_option_size(const char *prefix, size_t len,
>  #define MATCH_OPTION(prefix, arg, oparg) \
>      match_option_size((prefix "="), sizeof((prefix)), (arg), &(oparg))
>  
> -static void replace_string(char **str, const char *val)
> -{
> -    free(*str);
> -    *str = strdup(val);
> -}
> -
> -
>  /* Preserve a copy of a domain under a new name. Updates *r_domid */
>  static int preserve_domain(uint32_t *r_domid, libxl_event *event,
>                             libxl_domain_config *d_config)
> -- 
> 1.7.10.4
> 
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> http://lists.xen.org/xen-devel