From mboxrd@z Thu Jan 1 00:00:00 1970 From: arnd@arndb.de (Arnd Bergmann) Date: Thu, 25 Sep 2014 21:20:24 +0200 Subject: [PATCH] [RFC] Using hierarchy irqdomian to implement MTK intpol. In-Reply-To: References: <1411574696-1881-1-git-send-email-srv_yingjoe.chen@mediatek.com> Message-ID: <201409252120.24570.arnd@arndb.de> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Thursday 25 September 2014, Thomas Gleixner wrote: > On Thu, 25 Sep 2014, Joe.C wrote: > > From: "Joe.C" > > > > Here's the first draft of using hierarchy irqdomain to implement MTK intpol > > support. I have tested it and intpol works fine. Before continue, I'd like > > to get your comments. This is based on Jiang's hierarchy irqdomian [1] and > > my mediatek SoC basic support [2]. > > > > Simplified block diagram for interrupt: > > > > --------- --------- > > ---| CIRQ |------|ARM GIC| > > ---| |------| | > > ---| |------| | > > ---| |------| | > > ---| |------| | > > --------- --------- > > > > In device tree, interrupt-parent for other devices is cirq, child of gic. > > This describe HW better and allow device to specify polarity as it is sent > > by the device. I'm using interrupt-parent to specify irq domain parent in > > cirq now. Maybe adding another name like 'interrupt-domain-parent' will be > > better. > > I leave that to the DT folks. interrupt-parent really defines a domain already, I think using this is perfectly fine. Arnd From mboxrd@z Thu Jan 1 00:00:00 1970 From: Arnd Bergmann Subject: Re: [PATCH] [RFC] Using hierarchy irqdomian to implement MTK intpol. Date: Thu, 25 Sep 2014 21:20:24 +0200 Message-ID: <201409252120.24570.arnd@arndb.de> References: <1411574696-1881-1-git-send-email-srv_yingjoe.chen@mediatek.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org Cc: Thomas Gleixner , "Joe.C" , Mark Rutland , Benjamin Herrenschmidt , Boris BREZILLON , Russell King , yingjoe.chen-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, yh.chen-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org, nathan.chung-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org, Grant Likely "Joe.C" , devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Jason Cooper , Pawel Moll , Ian Campbell , Marc Zyngier , Rob Herring , Matthias Brugger , eddie.huang-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org, srv_heupstream-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org, hc.yen-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Sascha Hauer , Kumar Gala , Jiang Liu List-Id: devicetree@vger.kernel.org On Thursday 25 September 2014, Thomas Gleixner wrote: > On Thu, 25 Sep 2014, Joe.C wrote: > > From: "Joe.C" > > > > Here's the first draft of using hierarchy irqdomain to implement MTK intpol > > support. I have tested it and intpol works fine. Before continue, I'd like > > to get your comments. This is based on Jiang's hierarchy irqdomian [1] and > > my mediatek SoC basic support [2]. > > > > Simplified block diagram for interrupt: > > > > --------- --------- > > ---| CIRQ |------|ARM GIC| > > ---| |------| | > > ---| |------| | > > ---| |------| | > > ---| |------| | > > --------- --------- > > > > In device tree, interrupt-parent for other devices is cirq, child of gic. > > This describe HW better and allow device to specify polarity as it is sent > > by the device. I'm using interrupt-parent to specify irq domain parent in > > cirq now. Maybe adding another name like 'interrupt-domain-parent' will be > > better. > > I leave that to the DT folks. interrupt-parent really defines a domain already, I think using this is perfectly fine. Arnd -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751940AbaIYTV1 (ORCPT ); Thu, 25 Sep 2014 15:21:27 -0400 Received: from mout.kundenserver.de ([212.227.17.10]:64032 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750793AbaIYTVZ (ORCPT ); Thu, 25 Sep 2014 15:21:25 -0400 From: Arnd Bergmann To: linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH] [RFC] Using hierarchy irqdomian to implement MTK intpol. Date: Thu, 25 Sep 2014 21:20:24 +0200 User-Agent: KMail/1.12.2 (Linux/3.8.0-35-generic; KDE/4.3.2; x86_64; ; ) Cc: Thomas Gleixner , "Joe.C" , Mark Rutland , Benjamin Herrenschmidt , Boris BREZILLON , Russell King , yingjoe.chen@gmail.com, yh.chen@mediatek.com, nathan.chung@mediatek.com, Grant Likely , "Joe.C" , devicetree@vger.kernel.org, Jason Cooper , Pawel Moll , Ian Campbell , Marc Zyngier , Rob Herring , Matthias Brugger , eddie.huang@mediatek.com, srv_heupstream@mediatek.com, hc.yen@mediatek.com, linux-kernel@vger.kernel.org, Sascha Hauer , Kumar Gala , Jiang Liu References: <1411574696-1881-1-git-send-email-srv_yingjoe.chen@mediatek.com> In-Reply-To: MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <201409252120.24570.arnd@arndb.de> X-Provags-ID: V02:K0:qMdQ0Z9RtaovBkL8Fj6wOXTO/594MawpoqTd9C+baRa pjYR8nwacuNUbYX0KyTDB3h9fF1gmt7zBLQcaG/1BiWJRI1v9o KQecWWhTO7bcGPEFw6u3cQK6IdgU8/T04JV5eZoQDGbIIgtr0F fQQG3yS4uF9ek0tb4Q2EThgq0Ks7yQp3O3SdrY6VVDIKATZ4el DLuVyFBYyEld5dv5rc5e+39VZZ9f8VKV7IlkX38SV0ExdTTOai qhQNK8matZADCVtpR0QEl8fQXUswDYuug84BqTyvhBgMJKD2yM Mnu1wgIuy+MUCEO8aFBEbqqGwS9IhpVRIg97Dafh8DIun9APRx yFd8E13T4oBokFg4kb10= X-UI-Out-Filterresults: notjunk:1; Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thursday 25 September 2014, Thomas Gleixner wrote: > On Thu, 25 Sep 2014, Joe.C wrote: > > From: "Joe.C" > > > > Here's the first draft of using hierarchy irqdomain to implement MTK intpol > > support. I have tested it and intpol works fine. Before continue, I'd like > > to get your comments. This is based on Jiang's hierarchy irqdomian [1] and > > my mediatek SoC basic support [2]. > > > > Simplified block diagram for interrupt: > > > > --------- --------- > > ---| CIRQ |------|ARM GIC| > > ---| |------| | > > ---| |------| | > > ---| |------| | > > ---| |------| | > > --------- --------- > > > > In device tree, interrupt-parent for other devices is cirq, child of gic. > > This describe HW better and allow device to specify polarity as it is sent > > by the device. I'm using interrupt-parent to specify irq domain parent in > > cirq now. Maybe adding another name like 'interrupt-domain-parent' will be > > better. > > I leave that to the DT folks. interrupt-parent really defines a domain already, I think using this is perfectly fine. Arnd