From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 23/23 v5] docs/manual: document the asciidoc infra
Date: Fri, 26 Sep 2014 00:21:08 +0200 [thread overview]
Message-ID: <20140925222108.GC4184@free.fr> (raw)
In-Reply-To: <CAAXf6LW17bqSDpz_Jksqx5cm-KJ+_PRsgANKE_zotCU1gtmT5A@mail.gmail.com>
Thomas, All,
On 2014-09-24 22:07 +0200, Thomas De Schampheleire spake thusly:
> On Sun, Sep 14, 2014 at 1:07 PM, Yann E. MORIN <yann.morin.1998@free.fr> wrote:
> > +* +HTML+
> > +* +SPLIT_HTML+
> > +* +PDF+
> > +* +EPUB+
> > +* +TEXT+
>
> Any reason why this is capitalized and underscored like they were variables?
> There is nowhere a variable FOO_SPLIT_HTML_BAR, is there?
Yup, I'll set it to lowercase: they are the types of documents we
generate. That it needs to be in caps in variables is just a naming
convention.
> In fact, as far as I can see, the variables that should use them use
> them as follows:
>
> FOO_EXTRA_CHECK_DEPENDENCIES_split-html_HOOKS
>
> no?
Right. This is a bug. For _HOOKS variables in all package infras, we
exclusively use uppercase. So should we do here, too.
However, as you noticed, this is not correctly handled. I'll fix before
I repsin the series.
Thomas DS, also known as Lynx Eye! ;-)
> And related to that: the above is not in line with the variable
> $(2)_$(4)_ASCIIDOC_OPTS where $(4) is used instead of $(5).
>
> The above two comments, if needed, are of course to be fixed in earlier patches.
Right.
> > +* +FOO_EXTRA_CHECK_DEPENDENCIES_HOOKS+ to run additional tests on required
> > + components to generate the document. In AsciiDoc, it is possible to
> > + call filters, that is, programs that will parse an AsciiDoc block and
>
> My feeling says to loose the comma after 'that is' but I'm no native
> English writer.
Neither am I. Still, I believe that's the way it is used. For example:
https://en.wikipedia.org/wiki/Comma#Between_adjectives
Title is unrelated to the subject, but the sentence uses a comma after
"that is".
See also:
http://www.thefreedictionary.com/that+is
Quoting from two places:
To explain more clearly; in other words: on the first floor, that
is, the floor at street level.
When that introduces a relative clause, the clause is usu.
restrictive, that is, essential to the complete meaning of the
sentence.
Hmm... Sure thing, we learn a great deal of English on the Buildroot
mailing list. What was the last argument we had some time ago? hehe! :-)
> > +29: FOO_EXTRA_CHECK_DEPENDENCIES_TEXT += FOO_CHECK_MY_OTHER_PROG
>
> Have you checked that this actually works, and that it should not be
> text in lowercase?
Well, it used to work at one time, but now it does not any more.
As I said above, we want variables to be all uppercase, so the manual is
acurate in what we want; it's just a problem with the implementation,
that is, it is buggy. :-]
/me hides... Muhahaha! :-)
Regards,
Yann E. MORIN.
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
next prev parent reply other threads:[~2014-09-25 22:21 UTC|newest]
Thread overview: 83+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-14 11:07 [Buildroot] [PATCH 0/23 v5] gendoc infra: make it useable for other documents (branch yem/manual) Yann E. MORIN
2014-09-14 11:07 ` [Buildroot] [PATCH 01/23 v5] gendoc infra: cosmetic fixes Yann E. MORIN
2014-09-21 18:11 ` Thomas Petazzoni
2014-09-14 11:07 ` [Buildroot] [PATCH 02/23 v5] gendoc infra: move manual build location into $(BUILD_DIR)/manual Yann E. MORIN
2014-09-21 19:13 ` Thomas Petazzoni
2014-09-21 19:43 ` Yann E. MORIN
2014-09-14 11:07 ` [Buildroot] [PATCH 03/23 v5] gendoc infra: avoid a2x warning Yann E. MORIN
2014-09-14 11:07 ` [Buildroot] [PATCH 04/23 v5] gendoc infra: disable pdf manual generation if xsltproc is buggy Yann E. MORIN
2014-09-19 20:00 ` Thomas De Schampheleire
2014-09-19 20:15 ` Yann E. MORIN
2014-09-19 20:21 ` Thomas De Schampheleire
2014-09-14 11:07 ` [Buildroot] [PATCH 05/23 v5] docs/manual: get rid of legacy comment in GENDOC Yann E. MORIN
2014-09-19 19:44 ` Thomas De Schampheleire
2014-09-22 19:56 ` Samuel Martin
2014-09-14 11:07 ` [Buildroot] [PATCH 06/23 v5] docs/manual: copying the manual sources is a common action Yann E. MORIN
2014-09-19 20:13 ` Thomas De Schampheleire
2014-09-22 19:56 ` Samuel Martin
2014-09-14 11:07 ` [Buildroot] [PATCH 07/23 v5] docs/manual: simplify generation dependencies Yann E. MORIN
2014-09-19 20:18 ` Thomas De Schampheleire
2014-09-22 21:05 ` Yann E. MORIN
2014-09-22 19:56 ` Samuel Martin
2014-09-14 11:07 ` [Buildroot] [PATCH 08/23 v5] docs/manual: manual-update-lists is not a generic GENDOC rule Yann E. MORIN
2014-09-22 18:58 ` Thomas De Schampheleire
2014-09-22 19:56 ` Samuel Martin
2014-09-14 11:07 ` [Buildroot] [PATCH 09/23 v5] docs/manual: move manual-prepare-sources rule into GENDOC Yann E. MORIN
2014-09-22 19:01 ` Thomas De Schampheleire
2014-09-22 19:56 ` Samuel Martin
2014-09-14 11:07 ` [Buildroot] [PATCH 10/23 v5] docs/manual: do not hardcode name of the generated document Yann E. MORIN
2014-09-22 19:21 ` Thomas De Schampheleire
2014-09-22 19:57 ` Samuel Martin
2014-09-14 11:07 ` [Buildroot] [PATCH 11/23 v5] docs/manual: allow a document to declare where its ressources are Yann E. MORIN
2014-09-22 19:26 ` Thomas De Schampheleire
2014-09-22 19:43 ` Thomas De Schampheleire
2014-09-14 11:07 ` [Buildroot] [PATCH 12/23 v5] docs/manual: last pass at removing hard-coded path in GENDOC_INNER Yann E. MORIN
2014-09-22 19:38 ` Thomas De Schampheleire
2014-09-23 17:21 ` Yann E. MORIN
2014-09-24 6:54 ` Thomas De Schampheleire
2014-09-24 7:36 ` Samuel Martin
2014-09-24 20:17 ` Yann E. MORIN
2014-09-14 11:07 ` [Buildroot] [PATCH 13/23 v5] docs/manual: properly separate rules specific for our manual Yann E. MORIN
2014-09-22 19:47 ` Thomas De Schampheleire
2014-09-14 11:07 ` [Buildroot] [PATCH 14/23 v5] docs/manual: rename the generic dependency rules Yann E. MORIN
2014-09-22 20:20 ` Samuel Martin
2014-09-24 18:57 ` Thomas De Schampheleire
2014-09-14 11:07 ` [Buildroot] [PATCH 15/23 v5] docs/manual: allow documents to define some hooks, as for a package Yann E. MORIN
2014-09-22 20:20 ` Samuel Martin
2014-09-24 19:11 ` Thomas De Schampheleire
2014-09-24 21:00 ` Yann E. MORIN
2014-09-14 11:07 ` [Buildroot] [PATCH 16/23 v5] docs/manual: use the new hooks instead of gendoc rules Yann E. MORIN
2014-09-22 20:20 ` Samuel Martin
2014-09-24 19:18 ` Thomas De Schampheleire
2014-09-14 11:07 ` [Buildroot] [PATCH 17/23 v5] docs/manual: always look for ressources in destination directory Yann E. MORIN
2014-09-22 20:20 ` Samuel Martin
2014-09-24 19:21 ` Thomas De Schampheleire
2014-09-25 19:31 ` Yann E. MORIN
2014-09-26 10:50 ` Thomas De Schampheleire
2014-09-26 16:56 ` Yann E. MORIN
2014-09-14 11:07 ` [Buildroot] [PATCH 18/23 v5] docs: separate the GENDOC infra from our manual definition Yann E. MORIN
2014-09-22 20:42 ` Samuel Martin
2014-09-23 21:56 ` Yann E. MORIN
2014-09-24 19:28 ` Thomas De Schampheleire
2014-09-14 11:07 ` [Buildroot] [PATCH 19/23 v5] docs: rename the GENDOC infrastructure Yann E. MORIN
2014-09-22 20:42 ` Samuel Martin
2014-09-24 19:31 ` Thomas De Schampheleire
2014-09-24 21:06 ` Yann E. MORIN
2014-09-14 11:07 ` [Buildroot] [PATCH 20/23 v5] docs/asciidoc: call $(pkgname) and $(pkgdir) in a single place Yann E. MORIN
2014-09-22 20:42 ` Samuel Martin
2014-09-24 19:44 ` Thomas De Schampheleire
2014-09-24 21:16 ` Yann E. MORIN
2014-09-14 11:07 ` [Buildroot] [PATCH 21/23 v5] docs/asciidoc: make it possible to use $(@D) in hooks Yann E. MORIN
2014-09-22 20:48 ` Samuel Martin
2014-09-24 19:50 ` Thomas De Schampheleire
2014-09-25 17:47 ` Yann E. MORIN
2014-09-14 11:07 ` [Buildroot] [PATCH 22/23 v5] Makefile: enable generating documents from br2-external Yann E. MORIN
2014-09-22 20:48 ` Samuel Martin
2014-09-24 19:52 ` Thomas De Schampheleire
2014-09-14 11:07 ` [Buildroot] [PATCH 23/23 v5] docs/manual: document the asciidoc infra Yann E. MORIN
2014-09-22 21:00 ` Samuel Martin
2014-09-24 20:07 ` Thomas De Schampheleire
2014-09-24 20:16 ` Thomas De Schampheleire
2014-09-25 22:21 ` Yann E. MORIN [this message]
2014-09-26 10:48 ` Thomas De Schampheleire
2014-09-14 11:21 ` [Buildroot] [PATCH 0/23 v5] gendoc infra: make it useable for other documents (branch yem/manual) Yann E. MORIN
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140925222108.GC4184@free.fr \
--to=yann.morin.1998@free.fr \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.