From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:50019)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <edgar.iglesias@gmail.com>) id 1XXIBj-0005WX-R9
	for qemu-devel@nongnu.org; Thu, 25 Sep 2014 19:11:12 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <edgar.iglesias@gmail.com>) id 1XXIBa-0001R4-H7
	for qemu-devel@nongnu.org; Thu, 25 Sep 2014 19:11:03 -0400
Received: from mail-yk0-x22b.google.com ([2607:f8b0:4002:c07::22b]:56729)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <edgar.iglesias@gmail.com>) id 1XXIBa-0001PZ-4g
	for qemu-devel@nongnu.org; Thu, 25 Sep 2014 19:10:54 -0400
Received: by mail-yk0-f171.google.com with SMTP id 79so3744073ykr.2
	for <qemu-devel@nongnu.org>; Thu, 25 Sep 2014 16:10:48 -0700 (PDT)
Date: Fri, 26 Sep 2014 09:06:08 +1000
From: "Edgar E. Iglesias" <edgar.iglesias@gmail.com>
Message-ID: <20140925230608.GV16081@toto>
References: <1410582564-27687-1-git-send-email-edgar.iglesias@gmail.com>
	<1410582564-27687-8-git-send-email-edgar.iglesias@gmail.com>
	<CAFEAcA9YSd0CcMFT9ocBXoKhvFxgmZv6RgxEMSedSkCvv2Khkw@mail.gmail.com>
	<20140925222057.GS16081@toto>
	<CAFEAcA_+wdtSGUqxg9uun3s0un3qOqftPwsUU_ZX-M_nW-=yOQ@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAFEAcA_+wdtSGUqxg9uun3s0un3qOqftPwsUU_ZX-M_nW-=yOQ@mail.gmail.com>
Subject: Re: [Qemu-devel] [PATCH v6 07/10] target-arm: A64: Emulate the HVC
	insn
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Rob Herring <rob.herring@linaro.org>, Peter Crosthwaite <peter.crosthwaite@xilinx.com>, Fabian Aggeler <aggelerf@ethz.ch>, QEMU Developers <qemu-devel@nongnu.org>, Alexander Graf <agraf@suse.de>, Greg Bellows <greg.bellows@linaro.org>, Paolo Bonzini <pbonzini@redhat.com>, Alex =?iso-8859-1?Q?Benn=E9e?= <alex.bennee@linaro.org>, Christoffer Dall <christoffer.dall@linaro.org>, Richard Henderson <rth@twiddle.net>

On Fri, Sep 26, 2014 at 12:01:11AM +0100, Peter Maydell wrote:
> On 25 September 2014 23:20, Edgar E. Iglesias <edgar.iglesias@gmail.com> wrote:
> > On Thu, Sep 25, 2014 at 07:39:32PM +0100, Peter Maydell wrote:
> >> HCR.TGE isn't actually relevant for some exceptions
> >> (eg SMC), and the HVC handling you have below
> >> effectively ends up ignoring the route_to_el2
> >> information. That suggests to me that you should put
> >> this code in a default: case in the switch below.
> >
> > I don't really test nor support TGE so I'll just drop the TGE part.
> 
> I'd rather we just implemented it properly...

IMO, It's not about implementing it properly. It's about implementing the
EL3/2 support incrementally. The spec is too big to add all the features
at once.

Cheers,
Edgar