From: Bjorn Andersson <bjorn.andersson@sonymobile.com>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Josh Cartwright <joshc@codeaurora.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Pramod Gurav <pramod.gurav@smartplayin.com>,
Guenter Roeck <linux@roeck-us.net>
Subject: Re: [PATCH v2] pinctrl: qcom: use restart_notifier mechanism for ps_hold
Date: Thu, 25 Sep 2014 17:49:09 -0700 [thread overview]
Message-ID: <20140926004908.GC28481@sonymobile.com> (raw)
In-Reply-To: <CACRpkdauNieUTSAR=PGsvrXOrPNsBgyCPC9Ot=ZDXctfSdEp8w@mail.gmail.com>
On Thu 25 Sep 00:41 PDT 2014, Linus Walleij wrote:
> On Tue, Sep 23, 2014 at 10:59 PM, Josh Cartwright <joshc@codeaurora.org> wrote:
>
> > By converting to the restart_notifier mechanism for restart, we allow
> > for other mechanisms, like the watchdog, to be used for restart in the
> > case where PS_HOLD has failed to reset the chip.
> >
> > Since this mechanism may be one of several mechanisms registered, change
> > the post-ps_hold write timeout to be a more reasonable 1 second instead
> > of 10 seconds.
> >
> > Choose priority 128, as according to documentation, this mechanism "is
> > sufficient to restart the entire system".
> >
> > Cc: Pramod Gurav <pramod.gurav@smartplayin.com>
> > Cc: Guenter Roeck <linux@roeck-us.net>
> > Tested-by: Pramod Gurav <pramod.gurav@smartplayin.com>
> > Signed-off-by: Josh Cartwright <joshc@codeaurora.org>
> > ---
> >
> > Changes since v1:
> > - Simplified conditional notifier block registration
> > - Reduced wait time to 1s, which I've found to be sufficient on an IFC6410
> > board.
>
> Björn, are you OK with this patch?
>
Indeed, this is better than overriding arm_pm_restart.
Acked-by: Bjorn Andersson <bjorn.andersson@sonymobile.com>
Regards,
Bjorn
next prev parent reply other threads:[~2014-09-26 0:48 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-23 20:59 [PATCH v2] pinctrl: qcom: use restart_notifier mechanism for ps_hold Josh Cartwright
2014-09-23 21:57 ` Guenter Roeck
2014-09-25 7:41 ` Linus Walleij
2014-09-26 0:49 ` Bjorn Andersson [this message]
2014-09-26 8:37 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140926004908.GC28481@sonymobile.com \
--to=bjorn.andersson@sonymobile.com \
--cc=joshc@codeaurora.org \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=pramod.gurav@smartplayin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.