From: Ingo Molnar <mingo@kernel.org>
To: Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: linux-kernel@vger.kernel.org,
Adrian Hunter <adrian.hunter@intel.com>,
Borislav Petkov <bp@suse.de>,
Corey Ashford <cjashfor@linux.vnet.ibm.com>,
David Ahern <dsahern@gmail.com>, Don Zickus <dzickus@redhat.com>,
Frederic Weisbecker <fweisbec@gmail.com>,
Jean Pihet <jean.pihet@linaro.org>, Jiri Olsa <jolsa@redhat.com>,
Mike Galbraith <efault@gmx.de>,
Namhyung Kim <namhyung@kernel.org>,
Paul Mackerras <paulus@samba.org>,
Peter Zijlstra <peterz@infradead.org>,
Stephane Eranian <eranian@google.com>,
Arnaldo Carvalho de Melo <acme@redhat.com>
Subject: Re: [GIT PULL 00/14] perf tools polling fixes
Date: Fri, 26 Sep 2014 11:15:23 +0200 [thread overview]
Message-ID: <20140926091523.GB6664@gmail.com> (raw)
In-Reply-To: <1411682271-3771-1-git-send-email-acme@kernel.org>
* Arnaldo Carvalho de Melo <acme@kernel.org> wrote:
> Hi Ingo,
>
> Please consider pulling into tip/perf/core.
>
> Best Regards,
>
> - Arnaldo
>
> The following changes since commit 521e8bac67a71a6544274f39d5c61473e0e54ac0:
>
> perf/x86/intel/uncore: Update support for client uncore IMC PMU (2014-09-24 14:48:25 +0200)
>
> are available in the git repository at:
>
> git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git tags/perf-fdarray-for-mingo
>
> for you to fetch changes up to 46fb3c21d20415dd2693570c33d0ea6eb8745e04:
>
> perf trace: Filter out POLLHUP'ed file descriptors (2014-09-25 16:46:56 -0300)
>
> ----------------------------------------------------------------
> Infrastructure:
>
> We were not handling POLLHUP notifications for event file descriptors.
>
> Fix it by filtering entries in the events file descriptor array after
> poll returns, refcounting mmaps so that when the last fd pointing to
> a perf mmap goes away we do the unmap.
>
> User visible:
>
> Now 'record' and 'trace' properly exit when a target thread exits.
>
> Arnaldo Carvalho de Melo (14):
> perf evlist: Introduce perf_evlist__filter_pollfd method
> perf tests: Add test for perf_evlist__filter_pollfd()
> perf evlist: Monitor POLLERR and POLLHUP events too
> perf evlist: We need to poll all event file descriptors
> perf evlist: Allow growing pollfd on add method
> perf tests: Add pollfd growing test
> perf kvm stat live: Use perf_evlist__add_pollfd() instead of local equivalent
> perf evlist: Introduce poll method for common code idiom
> tools lib api: Adopt fdarray class from perf's evlist
> perf evlist: Refcount mmaps
> tools lib fd array: Allow associating an integer cookie with each entry
> perf evlist: Unmap when all refcounts to fd are gone and events drained
> perf record: Filter out POLLHUP'ed file descriptors
> perf trace: Filter out POLLHUP'ed file descriptors
>
> Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
>
> ----------------------------------------------------------------
> Arnaldo Carvalho de Melo (14):
> perf evlist: Introduce perf_evlist__filter_pollfd method
> perf tests: Add test for perf_evlist__filter_pollfd()
> perf evlist: Monitor POLLERR and POLLHUP events too
> perf evlist: We need to poll all event file descriptors
> perf evlist: Allow growing pollfd on add method
> perf tests: Add pollfd growing test
> perf kvm stat live: Use perf_evlist__add_pollfd() instead of local equivalent
> perf evlist: Introduce poll method for common code idiom
> tools lib api: Adopt fdarray class from perf's evlist
> perf evlist: Refcount mmaps
> tools lib fd array: Allow associating an integer cookie with each entry
> perf evlist: Unmap when all refcounts to fd are gone and events drained
> perf record: Filter out POLLHUP'ed file descriptors
> perf trace: Filter out POLLHUP'ed file descriptors
>
> tools/lib/api/Makefile | 7 +-
> tools/lib/api/fd/array.c | 127 ++++++++++++++++++++++
> tools/lib/api/fd/array.h | 46 ++++++++
> tools/perf/Makefile.perf | 3 +-
> tools/perf/builtin-kvm.c | 24 ++---
> tools/perf/builtin-record.c | 9 +-
> tools/perf/builtin-top.c | 4 +-
> tools/perf/builtin-trace.c | 7 +-
> tools/perf/tests/builtin-test.c | 8 ++
> tools/perf/tests/fdarray.c | 174 ++++++++++++++++++++++++++++++
> tools/perf/tests/open-syscall-tp-fields.c | 2 +-
> tools/perf/tests/perf-record.c | 2 +-
> tools/perf/tests/task-exit.c | 2 +-
> tools/perf/tests/tests.h | 2 +
> tools/perf/util/evlist.c | 105 +++++++++++++++---
> tools/perf/util/evlist.h | 16 ++-
> tools/perf/util/python.c | 6 +-
> 17 files changed, 501 insertions(+), 43 deletions(-)
> create mode 100644 tools/lib/api/fd/array.c
> create mode 100644 tools/lib/api/fd/array.h
> create mode 100644 tools/perf/tests/fdarray.c
Pulled into tip:perf/core, thanks a lot Arnaldo!
Ingo
prev parent reply other threads:[~2014-09-26 9:15 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-25 21:57 [GIT PULL 00/14] perf tools polling fixes Arnaldo Carvalho de Melo
2014-09-25 21:57 ` [PATCH 01/14] perf evlist: Introduce perf_evlist__filter_pollfd method Arnaldo Carvalho de Melo
2014-09-25 21:57 ` [PATCH 02/14] perf tests: Add test for perf_evlist__filter_pollfd() Arnaldo Carvalho de Melo
2014-09-25 21:57 ` [PATCH 03/14] perf evlist: Monitor POLLERR and POLLHUP events too Arnaldo Carvalho de Melo
2014-09-25 21:57 ` [PATCH 04/14] perf evlist: We need to poll all event file descriptors Arnaldo Carvalho de Melo
2014-09-25 21:57 ` [PATCH 05/14] perf evlist: Allow growing pollfd on add method Arnaldo Carvalho de Melo
2014-09-25 21:57 ` [PATCH 06/14] perf tests: Add pollfd growing test Arnaldo Carvalho de Melo
2014-09-25 21:57 ` [PATCH 07/14] perf kvm stat live: Use perf_evlist__add_pollfd() instead of local equivalent Arnaldo Carvalho de Melo
2014-09-25 21:57 ` [PATCH 08/14] perf evlist: Introduce poll method for common code idiom Arnaldo Carvalho de Melo
2014-09-25 21:57 ` [PATCH 09/14] tools lib api: Adopt fdarray class from perf's evlist Arnaldo Carvalho de Melo
2014-09-25 21:57 ` [PATCH 10/14] perf evlist: Refcount mmaps Arnaldo Carvalho de Melo
2014-09-25 21:57 ` [PATCH 11/14] tools lib fd array: Allow associating an integer cookie with each entry Arnaldo Carvalho de Melo
2014-09-25 21:57 ` [PATCH 12/14] perf evlist: Unmap when all refcounts to fd are gone and events drained Arnaldo Carvalho de Melo
2014-09-25 21:57 ` [PATCH 13/14] perf record: Filter out POLLHUP'ed file descriptors Arnaldo Carvalho de Melo
2014-09-25 21:57 ` [PATCH 14/14] perf trace: " Arnaldo Carvalho de Melo
2014-09-26 9:15 ` Ingo Molnar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140926091523.GB6664@gmail.com \
--to=mingo@kernel.org \
--cc=acme@kernel.org \
--cc=acme@redhat.com \
--cc=adrian.hunter@intel.com \
--cc=bp@suse.de \
--cc=cjashfor@linux.vnet.ibm.com \
--cc=dsahern@gmail.com \
--cc=dzickus@redhat.com \
--cc=efault@gmx.de \
--cc=eranian@google.com \
--cc=fweisbec@gmail.com \
--cc=jean.pihet@linaro.org \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=namhyung@kernel.org \
--cc=paulus@samba.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.