From mboxrd@z Thu Jan 1 00:00:00 1970 From: Olaf Hering Subject: Re: [PATCH 28/28] Separate runtime debug output from debug symbols Date: Fri, 26 Sep 2014 11:22:23 +0200 Message-ID: <20140926092223.GA2686@aepfle.de> References: <1411658423-18877-1-git-send-email-olaf@aepfle.de> <1411658423-18877-29-git-send-email-olaf@aepfle.de> <5424587E02000078000391F1@mail.emea.novell.com> <20140926081735.GA26733@aepfle.de> <20140926085459.GA29007@aepfle.de> <542548B1020000780003983D@mail.emea.novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <542548B1020000780003983D@mail.emea.novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Jan Beulich Cc: Wei Liu , Ian Campbell , Stefano Stabellini , Tim Deegan , Ian Jackson , xen-devel@lists.xen.org, Samuel Thibault , Keir Fraser , David Scott List-Id: xen-devel@lists.xenproject.org On Fri, Sep 26, Jan Beulich wrote: > >>> On 26.09.14 at 10:54, wrote: > > But I wonder how all that is supposed to work anyway for tools and xen? > > If I do "configure --disable-debug --disable-debug-info && make rpmball" > > xen still is built with debug=y. And to change that I have to use 'make > > rpmball debug=n' which affects also tools build. > With the hypervisor part of the build intentionally not being > controlled by the configure mechanism, I don't see how this can > be properly separated using the same command line override > mechanism to control both kinds of build sub-components. I think the bug is that everything uses debug=N. Perhaps that variable should be controlled by the subsystems? Like 'make debug_$subsys=N rpmbuild' which sets debug=N before the 'include $(XEN_ROOT)/Config.mk'. Then configure --enable-debug will set debug_$subsys in config/$subsys.mk which in turn sets debug=. Olaf