From: Christoph Hellwig <hch@infradead.org>
To: Dave Chinner <david@fromorbit.com>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH 1/5] xfs: refactor xlog_recover_process_data()
Date: Fri, 26 Sep 2014 04:42:38 -0700 [thread overview]
Message-ID: <20140926114238.GA16576@infradead.org> (raw)
In-Reply-To: <1411697952-24741-2-git-send-email-david@fromorbit.com>
On Fri, Sep 26, 2014 at 12:19:08PM +1000, Dave Chinner wrote:
> From: Dave Chinner <dchinner@redhat.com>
>
> Clean up xlog_recover_process_data() structure in preparation for
> fixing the allocation and freeing context of the transaction being
> recovered.
>
> Signed-off-by: Dave Chinner <dchinner@redhat.com>
Looks good. The only behavior change I could spot was that we now
validate the length of an ophdr even when starting a new transaction,
which seems sensible.
Nipick: maybe the lp argument to xlog_recover_process_ophdr should
be called end to make it more obvious?
Reviewed-by: Christoph Hellwig <hch@lst.de>
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2014-09-26 11:42 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-26 2:19 [PATCH 0/5 v2] xfs: clean up xlog_recover_process_data Dave Chinner
2014-09-26 2:19 ` [PATCH 1/5] xfs: refactor xlog_recover_process_data() Dave Chinner
2014-09-26 11:42 ` Christoph Hellwig [this message]
2014-09-26 23:22 ` Dave Chinner
2014-09-26 2:19 ` [PATCH 2/5] xfs: recovery of XLOG_UNMOUNT_TRANS leaks memory Dave Chinner
2014-09-26 12:01 ` Christoph Hellwig
2014-09-26 23:27 ` Dave Chinner
2014-09-26 2:19 ` [PATCH 3/5] xfs: fix double free in xlog_recover_commit_trans Dave Chinner
2014-09-26 2:19 ` [PATCH 4/5] xfs: reorganise transaction recovery item code Dave Chinner
2014-09-26 12:05 ` Christoph Hellwig
2014-09-26 2:19 ` [PATCH 5/5] xfs: refactor recovery transaction start handling Dave Chinner
2014-09-26 12:08 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140926114238.GA16576@infradead.org \
--to=hch@infradead.org \
--cc=david@fromorbit.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.