All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dave Jones <davej@redhat.com>
To: "Bryan O'Donoghue" <pure.logic@nexus-software.ie>
Cc: hpa@zytor.org, mingo@redhat.com, tglx@linutronix.de,
	hmh@hmh.eng.br, boon.leong.ong@intel.com, x86@kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] x86: Quark: Add if/else to setup_arch for Quark TLB bug
Date: Fri, 26 Sep 2014 13:35:46 -0400	[thread overview]
Message-ID: <20140926173546.GA9931@redhat.com> (raw)
In-Reply-To: <1411751985-4351-1-git-send-email-pure.logic@nexus-software.ie>

On Fri, Sep 26, 2014 at 06:19:45PM +0100, Bryan O'Donoghue wrote:
 > Quark X1000 incorrectly advertises PGE. In later the stages of boot
 > specifically in early_init_intel we setup_clear_cpu_cap for PGE.
 > At this point in time cpu_has_pge() will still be true.
 > 
 > Use the boot_cpu_data to decide if __flush_tlb_all() or __flush_tlb()
 > should be called subsequent to loading CR3
 
 > +	 * Flush the TLB after loading CR3
 > +	 *
 > +	 * Quark X1000 wrongly advertises PGE. Use boot_cpu_data to
 > +	 * to make sure the TLB is flushed correctly in the early
 > +	 * stage of setup_arch() for Quark X1000.
 > +	 * X86_FEATURE_PGE flag is only setup later stage at
 > +	 * early_cpu_init();
 > +	 */
 > +	if (boot_cpu_data.x86 == 5 && boot_cpu_data.x86_model == 9)
 > +		__flush_tlb();

This also needs a check for the cpu vendor, or this will apply
the workaround on for eg, AMD K6-III's.

	Dave
 

  reply	other threads:[~2014-09-26 17:36 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-26 17:19 [PATCH] x86: Quark: Add if/else to setup_arch for Quark TLB bug Bryan O'Donoghue
2014-09-26 17:35 ` Dave Jones [this message]
2014-09-26 17:40   ` Bryan O'Donoghue

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140926173546.GA9931@redhat.com \
    --to=davej@redhat.com \
    --cc=boon.leong.ong@intel.com \
    --cc=hmh@hmh.eng.br \
    --cc=hpa@zytor.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=pure.logic@nexus-software.ie \
    --cc=tglx@linutronix.de \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.