From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
To: Ian Jackson <Ian.Jackson@eu.citrix.com>
Cc: xen-devel@lists.xenproject.org,
Stefano Stabellini <stefano.stabellini@eu.citrix.com>,
Wei Liu <wei.liu2@citrix.com>,
Ian Campbell <ian.campbell@citrix.com>,
Roger Pau Monne <roger.pau@citrix.com>
Subject: Re: [PATCH for-4.5] pygrub: fix read sizes on FreeBSD
Date: Fri, 26 Sep 2014 14:08:21 -0400 [thread overview]
Message-ID: <20140926180821.GH5102@laptop.dumpdata.com> (raw)
In-Reply-To: <21541.35915.715975.709282@mariner.uk.xensource.com>
On Fri, Sep 26, 2014 at 04:54:51PM +0100, Ian Jackson wrote:
> Roger Pau Monne writes ("[PATCH for-4.5] pygrub: fix read sizes on FreeBSD"):
> > FreeBSD only allows reading multiples of sector size from raw disk devices
> > (character devices). This fix should only alter the behaviour of pygrub on
> > FreeBSD, the other supported OSes will continue using the same size.
> >
> > Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
> > Cc: Ian Jackson <ian.jackson@eu.citrix.com>
> > Cc: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
> > Cc: Ian Campbell <ian.campbell@citrix.com>
> > Cc: Wei Liu <wei.liu2@citrix.com>
> > Cc: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
>
> Acked-by: Ian Jackson <ian.jackson@eu.citrix.com>
>
> > I request a code freeze exception on the basis that this is a bugfix and it
> > doesn't change the behaviour on platforms different than FreeBSD.
>
> This sounds reasonable to me (but of course the decision is Konrad's).
Released-Acked-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
>
> Ian.
next prev parent reply other threads:[~2014-09-26 18:08 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-26 15:31 [PATCH for-4.5] pygrub: fix read sizes on FreeBSD Roger Pau Monne
2014-09-26 15:54 ` Ian Jackson
2014-09-26 18:08 ` Konrad Rzeszutek Wilk [this message]
2014-09-29 13:35 ` Ian Campbell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140926180821.GH5102@laptop.dumpdata.com \
--to=konrad.wilk@oracle.com \
--cc=Ian.Jackson@eu.citrix.com \
--cc=ian.campbell@citrix.com \
--cc=roger.pau@citrix.com \
--cc=stefano.stabellini@eu.citrix.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.