From mboxrd@z Thu Jan  1 00:00:00 1970
From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Subject: Re: [PATCH for-4.5] pygrub: fix read sizes on FreeBSD
Date: Fri, 26 Sep 2014 14:08:21 -0400
Message-ID: <20140926180821.GH5102@laptop.dumpdata.com>
References: <1411745495-20595-1-git-send-email-roger.pau@citrix.com>
	<21541.35915.715975.709282@mariner.uk.xensource.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta4.messagelabs.com ([85.158.143.247])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <konrad.wilk@oracle.com>) id 1XXZwX-0000vL-Rv
	for xen-devel@lists.xenproject.org; Fri, 26 Sep 2014 18:08:33 +0000
Content-Disposition: inline
In-Reply-To: <21541.35915.715975.709282@mariner.uk.xensource.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Ian Jackson <Ian.Jackson@eu.citrix.com>
Cc: xen-devel@lists.xenproject.org, Stefano Stabellini <stefano.stabellini@eu.citrix.com>, Wei Liu <wei.liu2@citrix.com>, Ian Campbell <ian.campbell@citrix.com>, Roger Pau Monne <roger.pau@citrix.com>
List-Id: xen-devel@lists.xenproject.org

On Fri, Sep 26, 2014 at 04:54:51PM +0100, Ian Jackson wrote:
> Roger Pau Monne writes ("[PATCH for-4.5] pygrub: fix read sizes on FreeBS=
D"):
> > FreeBSD only allows reading multiples of sector size from raw disk devi=
ces
> > (character devices). This fix should only alter the behaviour of pygrub=
 on
> > FreeBSD, the other supported OSes will continue using the same size.
> > =

> > Signed-off-by: Roger Pau Monn=E9 <roger.pau@citrix.com>
> > Cc: Ian Jackson <ian.jackson@eu.citrix.com>
> > Cc: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
> > Cc: Ian Campbell <ian.campbell@citrix.com>
> > Cc: Wei Liu <wei.liu2@citrix.com>
> > Cc: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
> =

> Acked-by: Ian Jackson <ian.jackson@eu.citrix.com>
> =

> > I request a code freeze exception on the basis that this is a bugfix an=
d it
> > doesn't change the behaviour on platforms different than FreeBSD.
> =

> This sounds reasonable to me (but of course the decision is Konrad's).

Released-Acked-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
> =

> Ian.