From: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
To: Randy Dunlap <rdunlap@infradead.org>, Akihiro Tsukada <tskd08@gmail.com>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>,
linux-next@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-media <linux-media@vger.kernel.org>,
Antti Palosaari <crope@iki.fi>
Subject: Re: linux-next: Tree for Sep 26 (media/pci/pt3)
Date: Fri, 26 Sep 2014 21:48:09 -0300 [thread overview]
Message-ID: <20140926214809.6443ea21@recife.lan> (raw)
In-Reply-To: <54259BFB.6010301@infradead.org>
Em Fri, 26 Sep 2014 10:01:47 -0700
Randy Dunlap <rdunlap@infradead.org> escreveu:
> On 09/26/14 04:10, Stephen Rothwell wrote:
> > Hi all,
> >
> > There will be no linux-next release on Monday.
> >
> > This has not been a good day :-(
> >
> > Changes since 20140925:
>
>
> on x86_64:
> when CONFIG_MODULES is not enabled:
>
> ../drivers/media/pci/pt3/pt3.c: In function 'pt3_attach_fe':
> ../drivers/media/pci/pt3/pt3.c:433:6: error: implicit declaration of function 'module_is_live' [-Werror=implicit-function-declaration]
:(
I didn't notice that weird I2C attach code on this driver.
Akihiro, could you please fix it? The entire I2C attach code at
pt3_attach looks weird. We should soon add support for the I2C
tuner attach code for all DVB drivers on a common place, just like
what we do for V4L drivers. That's why I didn't spend much time on
that piece of the code.
Yet, while we don't have it, please take a look at
drivers/media/v4l2-core/v4l2-device.c and do (almost) the same on
your driver, if possible, putting the I2C load module on a function.
That will make easier for us to replace such function when we'll add
core support for it. The function at v4l2-device for you to take
a look is: v4l2_device_register_subdev().
Thank you,
Mauro
prev parent reply other threads:[~2014-09-27 0:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-26 11:10 linux-next: Tree for Sep 26 Stephen Rothwell
2014-09-26 17:01 ` linux-next: Tree for Sep 26 (media/pci/pt3) Randy Dunlap
2014-09-27 0:48 ` Mauro Carvalho Chehab [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140926214809.6443ea21@recife.lan \
--to=mchehab@osg.samsung.com \
--cc=crope@iki.fi \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=rdunlap@infradead.org \
--cc=sfr@canb.auug.org.au \
--cc=tskd08@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.