From: Ben Pfaff <blp-l0M0P4e3n4LQT0dZR+AlfA@public.gmane.org>
To: Simon Horman <simon.horman-wFxRvT7yatFl57MIdRCFDg@public.gmane.org>
Cc: dev-yBygre7rU0TnMu66kgdUjQ@public.gmane.org,
netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH/RFC repost 2/8] netlink: Allow suppression of warnings for duplicate attributes
Date: Fri, 26 Sep 2014 16:55:42 -0700 [thread overview]
Message-ID: <20140926235542.GA20493@nicira.com> (raw)
In-Reply-To: <1411005311-11752-3-git-send-email-simon.horman-wFxRvT7yatFl57MIdRCFDg@public.gmane.org>
On Thu, Sep 18, 2014 at 10:55:05AM +0900, Simon Horman wrote:
> Add a multiple field to struct nl_policy which if set suppresses
> warning of duplicate attributes in nl_parse_nested().
>
> As is the case without this patch only the last occurrence of an
> attribute is stored in attrs by nl_parse_nested(). As such
> if the multiple field of struct nl_policy is set then it
> is up to the caller to parse the message to extract all the attributes.
>
> This is in preparation for allowing multiple OVS_SELECT_GROUP_ATTR_BUCKET
> attributes in a nested OVS_ACTION_ATTR_SELECT_GROUP attribute.
>
> Signed-off-by: Simon Horman <simon.horman-wFxRvT7yatFl57MIdRCFDg@public.gmane.org>
In the other case where we have duplicate attributes, it doesn't make
sense to process them with the policy functions, because we want to
see all of the instances of the duplicate attributes and policy
doesn't allow us to do that. I'm a little surprised that the new
attributes work differently. What's the idea?
next prev parent reply other threads:[~2014-09-26 23:55 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-18 1:55 [PATCH/RFC repost 0/8] Open vSwtich ODP Select Group Action Simon Horman
2014-09-18 1:55 ` [PATCH/RFC repost 1/8] odp: select group action attributes Simon Horman
2014-09-18 1:55 ` [PATCH/RFC repost 2/8] netlink: Allow suppression of warnings for duplicate attributes Simon Horman
[not found] ` <1411005311-11752-3-git-send-email-simon.horman-wFxRvT7yatFl57MIdRCFDg@public.gmane.org>
2014-09-26 23:55 ` Ben Pfaff [this message]
2014-10-09 1:18 ` [ovs-dev] " Simon Horman
2014-10-10 15:31 ` Ben Pfaff
2014-09-18 1:55 ` [PATCH/RFC repost 3/8] odp-util: formatting of datapath select group action Simon Horman
[not found] ` <1411005311-11752-4-git-send-email-simon.horman-wFxRvT7yatFl57MIdRCFDg@public.gmane.org>
2014-09-19 13:44 ` Thomas Graf
2014-09-24 4:55 ` Simon Horman
2014-09-18 1:55 ` [PATCH/RFC repost 4/8] datapath: execution of " Simon Horman
[not found] ` <1411005311-11752-5-git-send-email-simon.horman-wFxRvT7yatFl57MIdRCFDg@public.gmane.org>
2014-09-19 14:05 ` Thomas Graf
2014-09-24 6:01 ` Simon Horman
2014-09-24 8:19 ` Thomas Graf
2014-09-25 4:43 ` Simon Horman
2014-09-18 1:55 ` [PATCH/RFC repost 5/8] datapath: Move last_action() helper to datapath.h Simon Horman
[not found] ` <1411005311-11752-6-git-send-email-simon.horman-wFxRvT7yatFl57MIdRCFDg@public.gmane.org>
2014-09-19 14:06 ` Thomas Graf
2014-09-24 6:00 ` Simon Horman
[not found] ` <20140924060013.GB13314-IxS8c3vjKQDk1uMJSBkQmQ@public.gmane.org>
2014-09-24 8:20 ` Thomas Graf
2014-09-25 4:42 ` Simon Horman
2014-09-18 1:55 ` [PATCH/RFC repost 6/8] datapath: validation of select group action Simon Horman
2014-09-18 1:55 ` [PATCH/RFC repost 7/8] ofproto: translate datapath " Simon Horman
[not found] ` <1411005311-11752-8-git-send-email-simon.horman-wFxRvT7yatFl57MIdRCFDg@public.gmane.org>
2014-09-26 23:57 ` Ben Pfaff
2014-10-09 1:14 ` [ovs-dev] " Simon Horman
2014-10-13 20:46 ` Ben Pfaff
2014-10-14 4:54 ` Simon Horman
2014-09-18 1:55 ` [PATCH/RFC repost 8/8] hack: ofproto: enable odp select action Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140926235542.GA20493@nicira.com \
--to=blp-l0m0p4e3n4lqt0dzr+alfa@public.gmane.org \
--cc=dev-yBygre7rU0TnMu66kgdUjQ@public.gmane.org \
--cc=netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=simon.horman-wFxRvT7yatFl57MIdRCFDg@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.