From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1XXlTA-0005bB-TZ for mharc-grub-devel@gnu.org; Sat, 27 Sep 2014 02:27:00 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36875) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XXlT0-0005b3-Pi for grub-devel@gnu.org; Sat, 27 Sep 2014 02:26:59 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XXlSr-00068H-NB for grub-devel@gnu.org; Sat, 27 Sep 2014 02:26:50 -0400 Received: from mail-la0-x232.google.com ([2a00:1450:4010:c03::232]:60121) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XXlSr-000685-F9 for grub-devel@gnu.org; Sat, 27 Sep 2014 02:26:41 -0400 Received: by mail-la0-f50.google.com with SMTP id s18so156139lam.23 for ; Fri, 26 Sep 2014 23:26:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-type; bh=nZmV2t76cq/H6tLjmPxu1Mnl5+xsNyQEAGkrDe4wB1g=; b=JR115bkd1enh4YBaqBv/Wpy2AL668nh/xA7XFa4GdstyuM80C8oPdZ/kfSW6RpjTvn DNbO9iRfM969A7XdRPkonpTDHBLRUAKd/Y8hopVmISm3I/Kdk49SCOHLws4Jn4d0ctF5 /sSHx7yJovebwUWPd7KtCMdLSOJAEJKF/ESb6nqBlxkFGrSov6cv1xg54L2x9LfcHl2q vyLQL6OmwAigWiZjhPpkWFpR21r26dFDfhsJ83dJXZEYystMULRDyUo9mRqVdSb3MnqN ZeH6Am9kUf6+uXg51rdufs48rDFfL3ftZhPX2XoK5Yoao8P0PhupuHZVVOHEpw1pzPEQ 0ucw== X-Received: by 10.152.88.97 with SMTP id bf1mr24954915lab.58.1411799195481; Fri, 26 Sep 2014 23:26:35 -0700 (PDT) Received: from opensuse.site (ppp94-29-94-89.pppoe.spdop.ru. [94.29.94.89]) by mx.google.com with ESMTPSA id jp17sm2590824lab.18.2014.09.26.23.26.33 for (version=SSLv3 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Fri, 26 Sep 2014 23:26:34 -0700 (PDT) Date: Sat, 27 Sep 2014 10:26:32 +0400 From: Andrei Borzenkov To: Andrey Borzenkov Subject: Re: [PATCH] fix PXE transmit failure if P_UNKNOWN is not supported Message-ID: <20140927102632.16d446d1@opensuse.site> In-Reply-To: <20140726075503.38bd2db7@opensuse.site> References: <1406303622-31501-1-git-send-email-arvidjaar@gmail.com> <53D2CE5A.2040102@gmail.com> <20140726075503.38bd2db7@opensuse.site> X-Mailer: Claws Mail 3.9.2 (GTK+ 2.24.23; x86_64-suse-linux-gnu) Mime-Version: 1.0 Content-Type: multipart/signed; micalg=PGP-SHA1; boundary="Sig_/TioRYVVyZ7tdAv7K6dRh4mH"; protocol="application/pgp-signature" X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2a00:1450:4010:c03::232 Cc: The development of GNU GRUB , phcoder@gmail.com X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 27 Sep 2014 06:26:59 -0000 --Sig_/TioRYVVyZ7tdAv7K6dRh4mH Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable =D0=92 Sat, 26 Jul 2014 07:55:03 +0400 Andrey Borzenkov =D0=BF=D0=B8=D1=88=D0=B5=D1=82: > =D0=92 Fri, 25 Jul 2014 23:38:34 +0200 > Vladimir '=CF=86-coder/phcoder' Serbinenko =D0=BF=D0= =B8=D1=88=D0=B5=D1=82: >=20 > > On 25.07.2014 17:53, Andrey Borzenkov wrote: > > > Some PXE stacks do not support P_UNKNOWN in UNDI TRANSMIT; nothing is > > > sent at all. So strip Ethernet header for known frame types and let P= XE > > > stack add it. > > >=20 > > If I'm reading this patch correctly it discards several fields of the > > packet and i.a. kills vlan fields. >=20 > No, it does not. It discards Ethernet headers only when packet type is > IP or ARP. VLAN packet will have different type and will be passed > through as happens currently. >=20 Ping? It fixes real problem in the wild and this exact approach is used by other PXE stacks, so it is not as it is completely untested. If this is not acceptable - any idea how this problem can be fixed short of maintaining explicit black lists? >=20 > > Such low in the stack it should > > replace the header only in the case of perfect match. It will be perfect > > match in 99% of configs but we shouldn0t break configs on unaffected > > machines. --Sig_/TioRYVVyZ7tdAv7K6dRh4mH Content-Type: application/pgp-signature; name=signature.asc Content-Disposition: attachment; filename=signature.asc -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (GNU/Linux) iEYEARECAAYFAlQmWJgACgkQR6LMutpd94wRVwCgzYwdTujtGoE52ZA8lccV3uez AgAAnjhI5N9AxYi0L3X4C1ygNf4qqRT8 =+taV -----END PGP SIGNATURE----- --Sig_/TioRYVVyZ7tdAv7K6dRh4mH--