From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754173AbaI1PzG (ORCPT ); Sun, 28 Sep 2014 11:55:06 -0400 Received: from mga02.intel.com ([134.134.136.20]:37129 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751881AbaI1PzE (ORCPT ); Sun, 28 Sep 2014 11:55:04 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.04,614,1406617200"; d="scan'208";a="580282380" Date: Sun, 28 Sep 2014 20:55:40 +0530 From: Vinod Koul To: Dan Williams Cc: Roman Gushchin , "dmaengine@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH] net_dma: fix memory leak in dma_pin_iocvec_pages Message-ID: <20140928152540.GE1638@intel.com> References: <87d2bdcask.wl%klamm@yandex-team.ru> <20140924045701.GR24663@intel.com> <20140925161600.GC1638@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Sep 28, 2014 at 08:36:44AM -0700, Dan Williams wrote: > On Thu, Sep 25, 2014 at 9:16 AM, Vinod Koul wrote: > > On Tue, Sep 23, 2014 at 11:27:06PM -0700, Dan Williams wrote: > >> On Tue, Sep 23, 2014 at 9:57 PM, Vinod Koul wrote: > >> > On Wed, Sep 03, 2014 at 01:28:59PM +0400, Roman Gushchin wrote: > >> >> dma_pin_iovec_pages() calls get_user_pages() for each iovec. If > >> >> get_user_pages() returns a number smaller than the requested number, > >> >> dma_pin_iovec_pages() calls dma_unpin_iovec_pages(). It releases > >> >> previously allocated iovecs, but pages pinned by last get_user_pages() > >> >> call remain unreleased. > >> >> Fix this by calling put_page() for each such page. > >> >> > >> > Applied, thanks > >> > >> Vinod, I have a patch in my queue that completely removes the remnants > >> of NET_DMA. It's been deprecated for more than a few cycles now > >> without any reports to reinstate it. Time to push the final removal > >> patch. I'll rebase it on top of this so it doesn't collide. > > > > Okay, thanks for update. If you wnat I can remove it, so you don't need to > > rebase. > > > > Yes, please drop it. I'm sending the full removal to Linus. I added > Roman to the Reported-by and cc'd stable. Done, i have pushed the updated tree. -- ~Vinod