All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Eric Rost <eric.rost@mybabylon.net>
Cc: jason@lakedaemon.net, jake@lwn.net, antonysaraev@gmail.com,
	devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Fixed Conditional white space problems
Date: Sun, 28 Sep 2014 18:01:01 -0400	[thread overview]
Message-ID: <20140928220101.GA25770@kroah.com> (raw)
In-Reply-To: <20140928215426.GA10384@localhost>

On Sun, Sep 28, 2014 at 04:54:26PM -0500, Eric Rost wrote:
> My first patch, resent to appropriate multiple addresses!

That's great, but it doesn't belong here in the body of the changelog :)

> This patch fixes the following checkpatch.pl Warnings:
> 
> WARNING: suspect code indent for conditional statements (16, 16)
> +               for (r = 1; r < 2 * RCNT; r += 2 * SKEIN_UNROLL_512)
> [...]
> +               {
> 
> WARNING: suspect code indent for conditional statements (16, 16)
> +               for (r = 1; r <= 2 * RCNT; r += 2 * SKEIN_UNROLL_1024)
> [...]
> +               {

Your subject should give a clue as to what part of the kernel it
modifies, for this patch, it might look like:
	staging: skein: fixed conditional...

Care to fix that up and resend?

thanks,

greg k-h

  reply	other threads:[~2014-09-28 22:01 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-28 21:54 [PATCH] Fixed Conditional white space problems Eric Rost
2014-09-28 22:01 ` Greg KH [this message]
2014-09-28 22:53   ` Jason Cooper
2014-09-28 23:27     ` Joe Perches
2014-09-28 23:35       ` Eric Rost

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140928220101.GA25770@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=antonysaraev@gmail.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=eric.rost@mybabylon.net \
    --cc=jake@lwn.net \
    --cc=jason@lakedaemon.net \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.