From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] ci_udc: force full-speed operation if !CONFIG_USB_GADGET_DUALSPEED
Date: Sun, 28 Sep 2014 22:28:03 +0200 [thread overview]
Message-ID: <201409282228.03314.marex@denx.de> (raw)
In-Reply-To: <1411931555-15826-1-git-send-email-eric.nelson@boundarydevices.com>
On Sunday, September 28, 2014 at 09:12:35 PM, Eric Nelson wrote:
> Signed-off-by: Eric Nelson <eric.nelson@boundarydevices.com>
> ---
> drivers/usb/gadget/ci_udc.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/drivers/usb/gadget/ci_udc.c b/drivers/usb/gadget/ci_udc.c
> index 2572b34..9f2fd15 100644
> --- a/drivers/usb/gadget/ci_udc.c
> +++ b/drivers/usb/gadget/ci_udc.c
> @@ -777,6 +777,11 @@ static int ci_pullup(struct usb_gadget *gadget, int
> is_on) /* select DEVICE mode */
> writel(USBMODE_DEVICE, &udc->usbmode);
>
> +#if !defined(CONFIG_USB_GADGET_DUALSPEED) && defined(CONFIG_MX6)
> + /* force full-speed mode */
> + writel(readl(&udc->portsc)|(1<<24), &udc->portsc);
> +#endif
> +
setbits_le32() and I'm sure you know better than to use 1 << 24 . Please define
that bit proper. And you also know you should supply a commit message, right ?
> writel(0xffffffff, &udc->epflush);
>
> /* Turn on the USB connection by enabling the pullup resistor */
Best regards,
Marek Vasut
next prev parent reply other threads:[~2014-09-28 20:28 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-28 19:12 [U-Boot] [PATCH] ci_udc: force full-speed operation if !CONFIG_USB_GADGET_DUALSPEED Eric Nelson
2014-09-28 20:28 ` Marek Vasut [this message]
2014-09-28 22:01 ` Eric Nelson
2014-09-29 0:36 ` [U-Boot] [PATCH V2] usb: ci_udc: respect CONFIG_USB_GADGET_DUALSPEED Eric Nelson
2014-09-29 1:21 ` Felipe Balbi
2014-09-29 1:30 ` Eric Nelson
2014-09-29 1:35 ` [U-Boot] [PATCH] " Eric Nelson
2014-09-29 14:01 ` Felipe Balbi
2014-09-29 14:43 ` Marek Vasut
2014-09-29 17:04 ` Eric Nelson
2014-09-29 22:59 ` Marek Vasut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201409282228.03314.marex@denx.de \
--to=marex@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.