From: Peter Zijlstra <peterz@infradead.org>
To: Andi Kleen <andi@firstfloor.org>
Cc: dave@sr71.net, linux-kernel@vger.kernel.org, mingo@kernel.org,
eranian@google.com, x86@kernel.org,
Andi Kleen <ak@linux.intel.com>
Subject: Re: [PATCH 1/2] Use faster check for modules in backtrace on 64bit
Date: Mon, 29 Sep 2014 13:42:12 +0200 [thread overview]
Message-ID: <20140929114212.GG5430@worktop> (raw)
In-Reply-To: <1411774277-4198-2-git-send-email-andi@firstfloor.org>
On Fri, Sep 26, 2014 at 04:31:16PM -0700, Andi Kleen wrote:
>
> This has the (small) potential to get a false positive on a pointer to a
> data segment in a module. However since we also use the frame pointer
> chain as initial sanity check I think the danger of this is very low.
>
So this has come up several times; and the answer has always been, why
not make the __module_address() thing a rb-tree instead of a linear
loop. So I suppose I'll ask that again, why not?
next prev parent reply other threads:[~2014-09-29 11:42 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-26 23:31 Optimize backtrace code for perf PMI handler Andi Kleen
2014-09-26 23:31 ` [PATCH 1/2] Use faster check for modules in backtrace on 64bit Andi Kleen
2014-09-29 11:42 ` Peter Zijlstra [this message]
2014-09-29 15:21 ` Andi Kleen
2014-09-29 20:30 ` Andi Kleen
2014-09-30 8:58 ` Peter Zijlstra
2014-09-30 20:10 ` Andi Kleen
2014-10-02 10:57 ` Peter Zijlstra
2014-10-03 23:20 ` Andi Kleen
2014-09-26 23:31 ` [PATCH 2/2] x86: Only do a single page fault for copy_from_user_nmi Andi Kleen
2014-09-29 11:56 ` Peter Zijlstra
2014-09-29 15:26 ` Andi Kleen
2014-10-03 4:53 ` Ingo Molnar
2014-10-03 23:25 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140929114212.GG5430@worktop \
--to=peterz@infradead.org \
--cc=ak@linux.intel.com \
--cc=andi@firstfloor.org \
--cc=dave@sr71.net \
--cc=eranian@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.