From mboxrd@z Thu Jan  1 00:00:00 1970
From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Subject: Re: cpufreq implementation for OMAP under xen
	hypervisor.
Date: Mon, 29 Sep 2014 11:18:29 -0400
Message-ID: <20140929151829.GA31554@laptop.dumpdata.com>
References: <alpine.DEB.2.02.1409092235270.8137@kaball.uk.xensource.com>
	<1410342174.8217.270.camel@kazak.uk.xensource.com>
	<CAH_mUMM0iSCcCcYz1B13p5YdS+wvgBOMVJh-871v0Ga0f1bH8Q@mail.gmail.com>
	<alpine.DEB.2.02.1409101928370.8137@kaball.uk.xensource.com>
	<20140910193149.GB2898@laptop.dumpdata.com>
	<CAN58jitjKq+cjrRXu7CUFnz2ZgZCBapZcn2yZyx++JQfP3j9yA@mail.gmail.com>
	<alpine.DEB.2.02.1409241534200.22344@kaball.uk.xensource.com>
	<CAN58jis_Vws=tewrRkswCQC6FMLO5XNK9Ly__v0VDPr4Xd++hw@mail.gmail.com>
	<20140926181327.GK5102@laptop.dumpdata.com>
	<CAN58jivNzOVVXOyZXJgq++r9r8X2HO_Jnh_iV9ToUscpwvZUpw@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Content-Disposition: inline
In-Reply-To: <CAN58jivNzOVVXOyZXJgq++r9r8X2HO_Jnh_iV9ToUscpwvZUpw@mail.gmail.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Oleksandr Dmytryshyn <oleksandr.dmytryshyn@globallogic.com>
Cc: Ian Campbell <Ian.Campbell@citrix.com>, Stefano Stabellini <stefano.stabellini@eu.citrix.com>, jinsong.liu@alibaba-inc.com, Tim Deegan <tim@xen.org>, xen-devel <xen-devel@lists.xen.org>, Jan Beulich <jbeulich@suse.com>, jacob.shin@amd.com, Andrii Tseglytskyi <andrii.tseglytskyi@globallogic.com>
List-Id: xen-devel@lists.xenproject.org

On Mon, Sep 29, 2014 at 12:45:36PM +0300, Oleksandr Dmytryshyn wrote:
> On Fri, Sep 26, 2014 at 9:13 PM, Konrad Rzeszutek Wilk
> <konrad.wilk@oracle.com> wrote:
> >
> > > > The architecture looks sane to me. As Konrad pointed out, the difficulty
> > > > here is to be able to upstream the changes to the Linux driver in 2),
> > > > that you later in the thread identified as
> > > > drivers/cpufreq/cpufreq-cpu0.c.
> > > I'll write driver drivers/xen/xen-cpufreq.c and it replace original
> > > drivers/cpufreq/cpufreq.c
> > > And in the original cpufreq-cpu0 driver I'll chande only one string -
> > > path in the device tree
> > > with the settings for the CPUs opp:
> > > string
> > > np = of_find_node_by_path("/cpus/cpu@0");
> > > will changed to:
> > > np = of_find_node_by_path("/cpus/cpu@0/private_data/cpu@0");
> > >
> > > > If the changes are not invasive and you manage to upstream them in
> > > > Linux, I am all for this solution.
> > > In Linux kernel I should make few changes:
> > > 1. Enable CONFIG_CPU_FREQ_TABLE
> > > with disabled CONFIG_CPU_FREQ
> > > 2. Enable CONFIG_GENERIC_CPUFREQ_CPU0
> > > with disabled CONFIG_CPU_FREQ
> > >
> > > I mean make those configs dependent on
> > > CONFIG_CPU_FREQ or CONFIX_XEN_DOM0
> > > instead of
> > > CONFIG_CPU_FREQ
> >
> > Gosh no. Please make it work runtime.
> Sorry, Konrad, could You please explain what did You mean.

Don't make XEN options disable other options.

Distributions want one kernel that can satisfi a variety of platforms - not just specifc ones.