From: Jeff King <peff@peff.net>
To: Ben Walton <bdwalton@gmail.com>
Cc: gitster@pobox.com, git@vger.kernel.org
Subject: Re: [PATCH] Ensure SHELL_PATH is the hash bang for test suite askpass helper script.
Date: Mon, 29 Sep 2014 13:30:34 -0400 [thread overview]
Message-ID: <20140929173034.GA3845@peff.net> (raw)
In-Reply-To: <1411974127-5258-1-git-send-email-bdwalton@gmail.com>
On Mon, Sep 29, 2014 at 08:02:07AM +0100, Ben Walton wrote:
> The askpass script that is created for use by the test suite should
> use SHELL_PATH for its hash bang instead of /bin/sh. Commit 5a4352024
> introduced the use of idioms not supported in some legacy /bin/sh
> implementations.
>
> Use write_script to ensure this happens automatically. This lets us
> remove the chmod step as well, since write_script handles that.
>
> Signed-off-by: Ben Walton <bdwalton@gmail.com>
Thanks, this looks good to me.
-Peff
next prev parent reply other threads:[~2014-09-29 17:31 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-28 22:21 [PATCH] Use SHELL_PATH as hash bang in test suite askpass helper script Ben Walton
2014-09-28 23:14 ` Jeff King
2014-09-29 7:02 ` [PATCH] Ensure SHELL_PATH is the hash bang for " Ben Walton
2014-09-29 17:30 ` Jeff King [this message]
2014-09-29 17:49 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140929173034.GA3845@peff.net \
--to=peff@peff.net \
--cc=bdwalton@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.