Re: [libnftnl PATCH 2/2] examples: nft-set-parse-add: give batching support

[Pablo Neira Ayuso <pablo@netfilter.org>]

On Mon, Sep 29, 2014 at 05:35:44PM +0200, Arturo Borrero Gonzalez wrote:
> El 29/09/2014 17:02, "Pablo Neira Ayuso" <pablo@netfilter.org> escribió:
> >
> > On Fri, Sep 26, 2014 at 08:34:48PM +0200, Arturo Borrero Gonzalez wrote:
> > > @@ -66,6 +67,8 @@ static struct nft_set *set_parse_file(const char
> *file, uint16_t format)
> > >       }
> > >
> > >       nft_parse_err_free(err);
> > > +
> > > +     nft_set_attr_set_u32(s, NFT_SET_ATTR_ID, 1);
> > >       return s;
> > >
> > >  }
> >
> > I guess this works if you parse one single set definition in a file.
> > With more than one set, this will break.
> >
> > IIRC, Alvaro started a patch time ago to add a new interface to
> > libnftnl to handle the set internal id which was incomplete.
> >
> > Cc'ing him to know its status.
> 
> Yes, there is a issue here. But this code example just parse one set.

Right. Then applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html