All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alexander Aring <alex.aring@gmail.com>
To: Varka Bhadram <varkabhadram@gmail.com>
Cc: Simon Vincent <simon.vincent@xsilon.com>,
	linux-wpan@vger.kernel.org, jukka.rissanen@linux.intel.com
Subject: Re: ICMPv6 Redirects
Date: Tue, 30 Sep 2014 12:03:59 +0200	[thread overview]
Message-ID: <20140930100357.GD28060@omega> (raw)
In-Reply-To: <542A7D85.8050608@gmail.com>

On Tue, Sep 30, 2014 at 03:23:09PM +0530, Varka Bhadram wrote:
> On 09/30/2014 03:13 PM, Alexander Aring wrote:
> >
> >>May be IEEE-802.11 packets send to IPv6 Layer. In that case Its not dead code.
> >>
> >
> >802.11 data frames will be converted to ethernet frames.
> >
> >Why we now talking about 802.11? 6LoWPAN set always PACKET_HOST and then
> >we never have PACKET_BROADCAST set in IPv6 Layer. Then matching pkt_type
> >with PACKET_BROADCAST is dead code.
> 
> We don't know in which scenario the IPv6 Layer checking that statement.
> 
> The control is reaching there when they got ICMPv6 message of typeICMPV6_MGM_REPORT  <http://lxr.free-electrons.com/ident?i=ICMPV6_MGM_REPORT>  [1] .
> 
> We don't know the significance of it..??
> 

Yep, we don't know it and it doesn't matter, but override the pkt_type
to PACKET_HOST when we have a broadcast frame is wrong.

Broadcast means it's IPv6 BROADCAST or MULTICAST, the detection if
LOGICAL MULTICAST over BROADCAST xor BROADCAST over BROADCAST is IPv6 Layer.

These ICMPv6 messages check on this and it's currently broken.

- Alex

  parent reply	other threads:[~2014-09-30 10:04 UTC|newest]

Thread overview: 45+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-26 15:16 ICMPv6 Redirects Simon Vincent
2014-09-26 15:35 ` Alexander Aring
2014-09-26 16:26   ` Simon Vincent
2014-09-27  1:42     ` Alexander Aring
2014-09-29 10:20       ` Simon Vincent
2014-09-29 10:58         ` Varka Bhadram
2014-09-29 11:09           ` Simon Vincent
     [not found]             ` <5429441C.5000302@gmail.com>
     [not found]               ` <5429466F.4080506@gmail.com>
2014-09-29 11:53                 ` Alexander Aring
2014-09-29 11:57                   ` Alexander Aring
     [not found]                     ` <542949AE.30701@gmail.com>
2014-09-29 12:14                       ` Alexander Aring
     [not found]                       ` <54294BE7.7040501@gmail.com>
2014-09-29 12:14                         ` Alexander Aring
     [not found]                 ` <54295556.3030800@xsilon.com>
2014-09-29 13:12                   ` Alexander Aring
2014-09-29 13:30                     ` Alexander Aring
2014-09-29 13:33                       ` Simon Vincent
2014-09-29 13:38                         ` Alexander Aring
2014-09-29 13:41                           ` Alexander Aring
2014-09-29 13:51                           ` Simon Vincent
2014-09-29 13:54                             ` Varka Bhadram
2014-09-29 14:12                               ` Simon Vincent
2014-09-29 13:58                             ` Alexander Aring
2014-09-29 14:05                               ` Varka Bhadram
2014-09-29 14:12                                 ` Alexander Aring
2014-09-29 14:15                                   ` Varka Bhadram
2014-09-29 14:19                                     ` Alexander Aring
2014-09-29 14:12                               ` Simon Vincent
2014-09-29 14:17                                 ` Alexander Aring
2014-09-29 14:39                                 ` Alexander Aring
2014-09-29 14:51                                   ` Alexander Aring
2014-09-29 16:41                                 ` Alexander Aring
2014-09-30  8:34                                   ` Simon Vincent
2014-09-30  8:34                                     ` Varka Bhadram
2014-09-30  8:39                                     ` Alexander Aring
2014-09-30  8:46                                       ` Varka Bhadram
2014-09-30  8:53                                         ` Alexander Aring
2014-09-30  9:10                                           ` Varka Bhadram
2014-09-30  9:25                                             ` Alexander Aring
2014-09-30  9:35                                               ` Varka Bhadram
2014-09-30  9:43                                                 ` Alexander Aring
     [not found]                                                   ` <542A7D85.8050608@gmail.com>
2014-09-30 10:03                                                     ` Alexander Aring [this message]
2014-09-30 10:55                                                       ` Jukka Rissanen
2014-09-30 11:13                                                         ` Alexander Aring
2014-09-30 11:35                                                           ` Alexander Aring
2014-09-29 11:13         ` Alexander Aring
2014-09-29 11:23           ` Alexander Aring
2014-09-29 11:37             ` Alexander Aring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140930100357.GD28060@omega \
    --to=alex.aring@gmail.com \
    --cc=jukka.rissanen@linux.intel.com \
    --cc=linux-wpan@vger.kernel.org \
    --cc=simon.vincent@xsilon.com \
    --cc=varkabhadram@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.