From mboxrd@z Thu Jan  1 00:00:00 1970
From: Damien Lespiau <damien.lespiau@intel.com>
Subject: Re: [PATCH 74/89 v4] drm/i915/skl: Implement queue_flip
Date: Tue, 30 Sep 2014 13:19:20 +0100
Message-ID: <20140930121920.GG16626@strange.ger.corp.intel.com>
References: <CA+gsUGQX8DfnxGc4wCaoY71ii844VdZ07HDE3QqsD0aoP6hFfg@mail.gmail.com>
 <1412010826-15197-1-git-send-email-damien.lespiau@intel.com>
 <CA+gsUGSMWcr=LZ3SD5DmG1rhgWe6DaoDpYLm=Y6SZ-Y3QMeS+w@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mga01.intel.com (mga01.intel.com [192.55.52.88])
 by gabe.freedesktop.org (Postfix) with ESMTP id 98E7C6FB66
 for <intel-gfx@lists.freedesktop.org>; Tue, 30 Sep 2014 05:19:22 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <CA+gsUGSMWcr=LZ3SD5DmG1rhgWe6DaoDpYLm=Y6SZ-Y3QMeS+w@mail.gmail.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Paulo Zanoni <przanoni@gmail.com>
Cc: Intel Graphics Development <intel-gfx@lists.freedesktop.org>
List-Id: intel-gfx@lists.freedesktop.org

On Tue, Sep 30, 2014 at 09:08:35AM -0300, Paulo Zanoni wrote:
> > +static int intel_gen9_queue_flip(struct drm_device *dev,
> > +                                struct drm_crtc *crtc,
> > +                                struct drm_framebuffer *fb,
> > +                                struct drm_i915_gem_object *obj,
> > +                                struct intel_engine_cs *ring,
> > +                                uint32_t flags)
> > +{
> > +       struct intel_crtc *intel_crtc = to_intel_crtc(crtc);
> > +       uint32_t plane = 0, stride;
> > +       int ret;
> > +
> > +       switch(intel_crtc->pipe) {
> 
> I just noticed that the gen7 function checks for intel_crtc->plane
> instead of ->pipe. This shouldn't be a problem on Gen 9, right?
> 
> If that's not a problem: Reviewed-by: Paulo Zanoni <paulo.r.zanoni@intel.com>

Indeed, not a problem for all the platforms where crtc->plane ==
crtc->pipe (and I used pipe because I wanted to forget about that dark
past).

AFAICS, the only case where crtc->plane != crtc->pipe is when:

  (HAS_FBC(dev) && INTEL_INFO(dev)->gen < 4) is true

(see intel_primary_plane_create())

Thanks for the review!

-- 
Damien