All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Michael S. Tsirkin" <mst@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: weidong.huang@huawei.com, stefanha@redhat.com,
	qemu-devel@nongnu.org, luonengjun@huawei.com, armbru@redhat.com,
	peter.huangpeng@huawei.com, arei.gonglei@huawei.com,
	aliguori@amazon.com, lcapitulino@redhat.com, afaerber@suse.de,
	Gonglei <arei.gonglei@hotmail.com>
Subject: Re: [Qemu-devel] [PATCH v4 1/5] qdev: add description field in PropertyInfo struct
Date: Tue, 30 Sep 2014 16:55:08 +0300	[thread overview]
Message-ID: <20140930135508.GA3560@redhat.com> (raw)
In-Reply-To: <542AB1D6.4010900@redhat.com>

On Tue, Sep 30, 2014 at 03:36:22PM +0200, Paolo Bonzini wrote:
> Il 30/09/2014 15:33, Michael S. Tsirkin ha scritto:
> > > > 
> > > The Propertyinfo.name is used to the qdev property's type, please see PATCH 4:
> > > 
> > > -            info->type = g_strdup(prop->info->legacy_name ?: prop->info->name);
> > > +            info->type = g_strdup(prop->info->name);
> > 
> > I would say this one is more a string than an int.
> 
> At the QOM level it is an int, even though it secondarily accepts a
> string in "DD.F" format.
> 
> Paolo

That's the only way to specify a function, isn't it?
Maybe it's not a good idea to expose the QOM type in this case.

-- 
MST

  reply	other threads:[~2014-09-30 13:52 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-30  3:02 [Qemu-devel] [PATCH v4 0/5] add description field in ObjectProperty and PropertyInfo struct arei.gonglei
2014-09-30  3:02 ` [Qemu-devel] [PATCH v4 1/5] qdev: add description field in " arei.gonglei
2014-09-30 11:42   ` Michael S. Tsirkin
2014-09-30 13:14     ` Gonglei
2014-09-30 13:33       ` Michael S. Tsirkin
2014-09-30 13:36         ` Paolo Bonzini
2014-09-30 13:55           ` Michael S. Tsirkin [this message]
2014-09-30 13:53             ` Paolo Bonzini
2014-09-30 14:01               ` Michael S. Tsirkin
2014-09-30 14:02                 ` Paolo Bonzini
2014-10-01  4:05                   ` Gonglei
2014-09-30 14:01             ` Gonglei
2014-09-30  3:02 ` [Qemu-devel] [PATCH v4 2/5] qom: add description field in ObjectProperty struct arei.gonglei
2014-09-30 11:48   ` Michael S. Tsirkin
2014-09-30 13:18     ` Gonglei
2014-09-30  3:02 ` [Qemu-devel] [PATCH v4 3/5] qdev: set the object property's description to the qdev property's arei.gonglei
2014-09-30  3:02 ` [Qemu-devel] [PATCH v4 4/5] qmp: print descriptions of object properties arei.gonglei
2014-09-30 15:38   ` Eric Blake
2014-09-30  3:02 ` [Qemu-devel] [PATCH v4 5/5] qdev: drop legacy_name from qdev properties arei.gonglei
2014-09-30 11:43   ` Michael S. Tsirkin
2014-09-30 13:15     ` Gonglei
2014-09-30  8:54 ` [Qemu-devel] [PATCH v4 0/5] add description field in ObjectProperty and PropertyInfo struct Paolo Bonzini
2014-09-30 11:35 ` Michael S. Tsirkin
2014-09-30 11:53   ` Paolo Bonzini
2014-09-30 12:09   ` Markus Armbruster
2014-09-30 13:05   ` Gonglei
2014-09-30 13:32 ` Michael S. Tsirkin
2014-09-30 14:05   ` Gonglei

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140930135508.GA3560@redhat.com \
    --to=mst@redhat.com \
    --cc=afaerber@suse.de \
    --cc=aliguori@amazon.com \
    --cc=arei.gonglei@hotmail.com \
    --cc=arei.gonglei@huawei.com \
    --cc=armbru@redhat.com \
    --cc=lcapitulino@redhat.com \
    --cc=luonengjun@huawei.com \
    --cc=pbonzini@redhat.com \
    --cc=peter.huangpeng@huawei.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    --cc=weidong.huang@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.