All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@infradead.org>
To: Hannes Reinecke <hare@suse.de>
Cc: James Bottomley <jbottomley@parallels.com>,
	Christoph Hellwig <hch@infradead.org>,
	linux-scsi@vger.kernel.org, Robert Elliott <elliott@hp.com>
Subject: Re: [PATCH 19/23] sd: Cleanup logging
Date: Tue, 30 Sep 2014 07:58:58 -0700	[thread overview]
Message-ID: <20140930145858.GI1206@infradead.org> (raw)
In-Reply-To: <1412077852-40893-20-git-send-email-hare@suse.de>

On Tue, Sep 30, 2014 at 01:50:48PM +0200, Hannes Reinecke wrote:
> Open-code scsi_print_result in sd.c, and cleanup logging to
> not print duplicate informations.
> 
> With that we can remove scsi_show_result in constants.c

Looks good,

Reviewed-by: Christoph Hellwig <hch@lst.de>

  reply	other threads:[~2014-09-30 14:59 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-30 11:50 [PATCHv4 00/23] scsi logging update (the boring part) Hannes Reinecke
2014-09-30 11:50 ` [PATCH 01/23] Remove scsi_cmd_print_sense_hdr() Hannes Reinecke
2014-09-30 11:50 ` [PATCH 02/23] sd: Remove scsi_print_sense() in sd_done() Hannes Reinecke
2014-09-30 11:50 ` [PATCH 03/23] aha152x: Debug output update and whitespace cleanup Hannes Reinecke
2014-09-30 14:52   ` Christoph Hellwig
2014-09-30 11:50 ` [PATCH 04/23] scsi: introduce sdev_prefix_printk() Hannes Reinecke
2014-09-30 11:50 ` [PATCH 05/23] scsi: Use sdev as argument for sense code printing Hannes Reinecke
2014-09-30 11:50 ` [PATCH 06/23] acornscsi: use scsi_print_command() Hannes Reinecke
2014-09-30 14:52   ` Christoph Hellwig
2014-09-30 11:50 ` [PATCH 07/23] fas216: Update logging messages Hannes Reinecke
2014-09-30 14:55   ` Christoph Hellwig
2014-09-30 11:50 ` [PATCH 08/23] 53c700: remove scsi_print_sense() usage Hannes Reinecke
2014-09-30 14:55   ` Christoph Hellwig
2014-09-30 11:50 ` [PATCH 09/23] scsi: stop decoding if scsi_normalize_sense() fails Hannes Reinecke
2014-09-30 14:56   ` Christoph Hellwig
2014-09-30 11:50 ` [PATCH 10/23] scsi: do not decode sense extras Hannes Reinecke
2014-09-30 11:50 ` [PATCH 11/23] scsi: use 'bool' as return value for scsi_normalize_sense() Hannes Reinecke
2014-09-30 11:50 ` [PATCH 12/23] scsi: remove scsi_print_status() Hannes Reinecke
2014-09-30 11:50 ` [PATCH 13/23] Implement scsi_opcode_sa_name Hannes Reinecke
2014-09-30 11:50 ` [PATCH 14/23] scsi: merge print_opcode_name() Hannes Reinecke
2014-09-30 11:50 ` [PATCH 15/23] scsi: consolidate opcode lookup in scsi_opcode_sa_name() Hannes Reinecke
2014-09-30 11:50 ` [PATCH 16/23] scsi: remove last argument from print_opcode_name() Hannes Reinecke
2014-09-30 14:57   ` Christoph Hellwig
2014-09-30 11:50 ` [PATCH 17/23] scsi: Remove scsi_print_command when calling abort Hannes Reinecke
2014-09-30 14:57   ` Christoph Hellwig
2014-09-30 11:50 ` [PATCH 18/23] scsi: separate out scsi_(host|driver)byte_string() Hannes Reinecke
2014-09-30 14:58   ` Christoph Hellwig
2014-09-30 11:50 ` [PATCH 19/23] sd: Cleanup logging Hannes Reinecke
2014-09-30 14:58   ` Christoph Hellwig [this message]
2014-09-30 11:50 ` [PATCH 20/23] scsi: simplify scsi_log_(send|completion) Hannes Reinecke
2014-09-30 15:19   ` Christoph Hellwig
2014-09-30 11:50 ` [PATCH 21/23] scsi: fixup logging messages in scsi_error.c Hannes Reinecke
2014-09-30 15:20   ` Christoph Hellwig
2014-09-30 11:50 ` [PATCH 22/23] scsi: use shost argument in scsi_eh_prt_fail_stats Hannes Reinecke
2014-09-30 15:20   ` Christoph Hellwig
2014-09-30 11:50 ` [PATCH 23/23] scsi_trace: add tracepoint for completion Hannes Reinecke
2014-09-30 15:21   ` Christoph Hellwig
2014-09-30 18:22     ` Hannes Reinecke

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140930145858.GI1206@infradead.org \
    --to=hch@infradead.org \
    --cc=elliott@hp.com \
    --cc=hare@suse.de \
    --cc=jbottomley@parallels.com \
    --cc=linux-scsi@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.