From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bjorn Andersson Subject: Re: [PATCH v7 1/3] mfd: devicetree: bindings: Add Qualcomm RPM DT binding Date: Tue, 30 Sep 2014 08:28:39 -0700 Message-ID: <20140930152838.GN28481@sonymobile.com> References: <1411428329-23172-1-git-send-email-bjorn.andersson@sonymobile.com> <1411428329-23172-2-git-send-email-bjorn.andersson@sonymobile.com> <334C6A04-9607-4E97-A7A7-2FEED5986E57@codeaurora.org> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Received: from seldrel01.sonyericsson.com ([212.209.106.2]:5236 "EHLO seldrel01.sonyericsson.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750782AbaI3P2a convert rfc822-to-8bit (ORCPT ); Tue, 30 Sep 2014 11:28:30 -0400 Content-Disposition: inline In-Reply-To: <334C6A04-9607-4E97-A7A7-2FEED5986E57@codeaurora.org> Sender: linux-arm-msm-owner@vger.kernel.org List-Id: linux-arm-msm@vger.kernel.org To: Kumar Gala Cc: Rob Herring , Mark Brown , Lee Jones , Pawel Moll , Andy Gross , Mark Rutland , Kevin Hilman , Josh Cartwright , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-arm-msm@vger.kernel.org" On Wed 24 Sep 09:39 PDT 2014, Kumar Gala wrote: >=20 > On Sep 22, 2014, at 6:25 PM, Bjorn Andersson wrote: >=20 [..] > > diff --git a/Documentation/devicetree/bindings/mfd/qcom-rpm.txt b/D= ocumentation/devicetree/bindings/mfd/qcom-rpm.txt [..] > > +- qcom,ipc: > > + Usage: required > > + Value type: > > + > > + Definition: three entries specifying the outgoing ipc bit use= d for > > + signaling the RPM: > > + - phandle to a syscon node representing the apcs = registers > > + - u32 representing offset to the register within = the syscon > > + - u32 representing the ipc bit within the registe= r > > + >=20 > Does this really ever differ for the SoCs, and even if it does why do= we need > to encode it in DT. Can=92t we determine it via the compatible setti= ng? >=20 The two offsets could be hard coded, especially based on the compatible= =2E But I don't know if it's worth respinning this just to get those two nu= mber out of here. Also this is now "symmetric" with the smd use cases, where it shouldn't be hard coded. Regards, Bjorn From mboxrd@z Thu Jan 1 00:00:00 1970 From: bjorn.andersson@sonymobile.com (Bjorn Andersson) Date: Tue, 30 Sep 2014 08:28:39 -0700 Subject: [PATCH v7 1/3] mfd: devicetree: bindings: Add Qualcomm RPM DT binding In-Reply-To: <334C6A04-9607-4E97-A7A7-2FEED5986E57@codeaurora.org> References: <1411428329-23172-1-git-send-email-bjorn.andersson@sonymobile.com> <1411428329-23172-2-git-send-email-bjorn.andersson@sonymobile.com> <334C6A04-9607-4E97-A7A7-2FEED5986E57@codeaurora.org> Message-ID: <20140930152838.GN28481@sonymobile.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Wed 24 Sep 09:39 PDT 2014, Kumar Gala wrote: > > On Sep 22, 2014, at 6:25 PM, Bjorn Andersson wrote: > [..] > > diff --git a/Documentation/devicetree/bindings/mfd/qcom-rpm.txt b/Documentation/devicetree/bindings/mfd/qcom-rpm.txt [..] > > +- qcom,ipc: > > + Usage: required > > + Value type: > > + > > + Definition: three entries specifying the outgoing ipc bit used for > > + signaling the RPM: > > + - phandle to a syscon node representing the apcs registers > > + - u32 representing offset to the register within the syscon > > + - u32 representing the ipc bit within the register > > + > > Does this really ever differ for the SoCs, and even if it does why do we need > to encode it in DT. Can?t we determine it via the compatible setting? > The two offsets could be hard coded, especially based on the compatible. But I don't know if it's worth respinning this just to get those two number out of here. Also this is now "symmetric" with the smd use cases, where it shouldn't be hard coded. Regards, Bjorn