From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:55083)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <benoit.canet@irqsave.net>) id 1XZ2yC-0006bs-Uc
	for qemu-devel@nongnu.org; Tue, 30 Sep 2014 15:20:25 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <benoit.canet@irqsave.net>) id 1XZ2y8-0006Qg-Gq
	for qemu-devel@nongnu.org; Tue, 30 Sep 2014 15:20:20 -0400
Received: from lputeaux-656-01-25-125.w80-12.abo.wanadoo.fr
	([80.12.84.125]:36099 helo=paradis.irqsave.net)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <benoit.canet@irqsave.net>) id 1XZ2y8-0006QY-A3
	for qemu-devel@nongnu.org; Tue, 30 Sep 2014 15:20:16 -0400
Date: Tue, 30 Sep 2014 21:17:48 +0200
From: =?iso-8859-1?Q?Beno=EEt?= Canet <benoit.canet@irqsave.net>
Message-ID: <20140930191748.GA14250@irqsave.net>
References: <1411744797-17121-1-git-send-email-boriss@gmail.com>
	<20140929214648.GA7692@irqsave.net>
	<CAF8zAAOK_n6FuEG+TCg31T1q5C=LJ+X4T=D5rEqMaOqGZ3kP=A@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
In-Reply-To: <CAF8zAAOK_n6FuEG+TCg31T1q5C=LJ+X4T=D5rEqMaOqGZ3kP=A@mail.gmail.com>
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH 0/2] Virtio-9p live migration patchset
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Boris Sukholitko <boriss@gmail.com>
Cc: =?iso-8859-1?Q?Beno=EEt?= Canet <benoit.canet@irqsave.net>, qemu-devel@nongnu.org

The Tuesday 30 Sep 2014 =E0 22:08:12 (+0300), Boris Sukholitko wrote :
> On Tue, Sep 30, 2014 at 12:46 AM, Beno=EEt Canet <benoit.canet@irqsave.=
net> wrote:
> > The Friday 26 Sep 2014 =E0 18:19:55 (+0300), Boris Sukholitko wrote :
> >> This patchset is a small rebase of the 9p live migration patches mad=
e a year
> >> ago by Benoit Canet.
> >>
> >> See http://lists.gnu.org/archive/html/qemu-devel/2013-04/msg02190.ht=
ml
> >> for the previous thread.
> >>
> >> I took the liberty to drop the second patch (waiting for completion =
of 9p
> >> operations) as it wasn't working in my testing.
> >
> > It's probable that the second patch has bitrot but I remember I was a=
sked to
> > write it for a meaningfull reason.
>=20
> AFAICT, the reason was to drain requests queue before saving the state.
>=20
> Unfortunately, releasing BQL haven't led to the callbacks being execute=
d.
> Therefore deadlock ensued.
>=20
> > Maybe you should give it a bit more love to resurect it properly.
> >
>=20
> I probably should. Still, IMHO, the two patches work good enough
> to deserve merging on their own right :)

I am afraid nobody will want to merge a patchset where there is a
theorical potential bug.

It should work as well on paper as on silicon.

Best regards

Beno=EEt

>=20
> Thanks,
> Boris.
>=20
> > Best regards
> >
> > Beno=EEt
> >
> >>
> >> Thanks,
> >> Boris.
> >>
> >> Boris Sukholitko (2):
> >>   virtio-9p: Add support for 9p migration.
> >>   virtio-9p: Remove migration blockers.
> >>
> >>  hw/9pfs/virtio-9p-device.c | 152 ++++++++++++++++++++++++++++++++++=
+++++++++++
> >>  hw/9pfs/virtio-9p.c        |  24 -------
> >>  hw/9pfs/virtio-9p.h        |   2 -
> >>  3 files changed, 152 insertions(+), 26 deletions(-)
> >>
> >> --
> >> 2.0.2
> >>
> >>
>=20