From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nicolin Chen Subject: Re: [PATCH] ASoC: fsl: fix dependencies for wm8962 Date: Tue, 30 Sep 2014 12:43:44 -0700 Message-ID: <20140930194340.GA13318@Alpha> References: <1950588.ErdGoiHh8p@wuerfel> <20140930164510.GF4273@sirena.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-pd0-f180.google.com (mail-pd0-f180.google.com [209.85.192.180]) by alsa0.perex.cz (Postfix) with ESMTP id 47B0F260442 for ; Tue, 30 Sep 2014 21:43:52 +0200 (CEST) Received: by mail-pd0-f180.google.com with SMTP id fp1so5736289pdb.11 for ; Tue, 30 Sep 2014 12:43:50 -0700 (PDT) Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: Fabio Estevam Cc: "linux-arm-kernel@lists.infradead.org" , "alsa-devel@alsa-project.org" , Mark Brown , Liam Girdwood , Arnd Bergmann List-Id: alsa-devel@alsa-project.org On Tue, Sep 30, 2014 at 02:38:49PM -0300, Fabio Estevam wrote: > On Tue, Sep 30, 2014 at 1:45 PM, Mark Brown wrote: > > That select shouldn't be there in the first place, I asked Nicolin to > > fix this when I applied the driver but he's not got round to it yet. > > Would the below change be a proper fix? > > diff --git a/sound/soc/fsl/Kconfig b/sound/soc/fsl/Kconfig > index 6164e78..081e406 100644 > --- a/sound/soc/fsl/Kconfig > +++ b/sound/soc/fsl/Kconfig > - select SND_SOC_CS42XX8_I2C > - select SND_SOC_SGTL5000 > - select SND_SOC_WM8962 Okay..if Mark means this...I think it makes sense to me now. But in this case, we shall add them into imx_v6_v7_defconfig instead. Thank you Nicolin From mboxrd@z Thu Jan 1 00:00:00 1970 From: nicoleotsuka@gmail.com (Nicolin Chen) Date: Tue, 30 Sep 2014 12:43:44 -0700 Subject: [PATCH] ASoC: fsl: fix dependencies for wm8962 In-Reply-To: References: <1950588.ErdGoiHh8p@wuerfel> <20140930164510.GF4273@sirena.org.uk> Message-ID: <20140930194340.GA13318@Alpha> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Tue, Sep 30, 2014 at 02:38:49PM -0300, Fabio Estevam wrote: > On Tue, Sep 30, 2014 at 1:45 PM, Mark Brown wrote: > > That select shouldn't be there in the first place, I asked Nicolin to > > fix this when I applied the driver but he's not got round to it yet. > > Would the below change be a proper fix? > > diff --git a/sound/soc/fsl/Kconfig b/sound/soc/fsl/Kconfig > index 6164e78..081e406 100644 > --- a/sound/soc/fsl/Kconfig > +++ b/sound/soc/fsl/Kconfig > - select SND_SOC_CS42XX8_I2C > - select SND_SOC_SGTL5000 > - select SND_SOC_WM8962 Okay..if Mark means this...I think it makes sense to me now. But in this case, we shall add them into imx_v6_v7_defconfig instead. Thank you Nicolin