From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lina Iyer Subject: Re: [PATCH v7 5/7] qcom: cpuidle: Add cpuidle driver for QCOM cpus Date: Tue, 30 Sep 2014 14:36:52 -0600 Message-ID: <20140930203652.GE528@ilina-mac.local> References: <1411779495-39724-1-git-send-email-lina.iyer@linaro.org> <1411779495-39724-6-git-send-email-lina.iyer@linaro.org> <20140929153154.GF2165@e102568-lin.cambridge.arm.com> <7hmw9hypj9.fsf@deeprootsystems.com> <7h8ul1x86o.fsf@deeprootsystems.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Return-path: Content-Disposition: inline In-Reply-To: <7h8ul1x86o.fsf@deeprootsystems.com> Sender: linux-pm-owner@vger.kernel.org To: Kevin Hilman Cc: Nicolas Pitre , Lorenzo Pieralisi , "linux-pm@vger.kernel.org" , "linux-arm-msm@vger.kernel.org" , "daniel.lezcano@linaro.org" , "sboyd@codeaurora.org" , "msivasub@codeaurora.org" , "linux-arm-kernel@lists.infradead.org" , "galak@codeaurora.org" List-Id: linux-arm-msm@vger.kernel.org On Tue, Sep 30 2014 at 12:41 -0600, Kevin Hilman wrote: >Nicolas Pitre writes: > >> On Tue, 30 Sep 2014, Kevin Hilman wrote: >> >>> On Tue, Sep 30, 2014 at 10:51 AM, Nicolas Pitre >>> wrote: >>> > On Tue, 30 Sep 2014, Kevin Hilman wrote: >>> > >>> >> Lorenzo Pieralisi writes: > >[...] > >>> >> > This may be misleading. Call it PlatformWFI or something like that, not WFI if >>> >> > that's not what it is. >>> >> >>> >> This gets at a little pet peeve of mine: >>> >> >>> >> IMO, naming any state with "WFI" is a bit confusing, because typically >>> >> *every* idle state is entered by one (or more) CPU executing WFI, no? >>> > >>> > Agreed. >>> > >>> > The only state called "WFI" should be the one that only executes the WFI >>> > instruction without any other hardware setup around it. >>> >>> Well, I would go even further in that none of the states should be >>> called WFI, because WFI is used to enter all of them. >> >> Fair enough. >> >> So let's fix this by finding a name for that state that consists of only >> executing WFI and that every SOC has. >> >> Suggestions? > >The DT idle-states binding doc (though seemingly written more with >arm64 and SBSA in mind) uses "standby" for the shallowest idle. > Standby - looks good to me. From mboxrd@z Thu Jan 1 00:00:00 1970 From: lina.iyer@linaro.org (Lina Iyer) Date: Tue, 30 Sep 2014 14:36:52 -0600 Subject: [PATCH v7 5/7] qcom: cpuidle: Add cpuidle driver for QCOM cpus In-Reply-To: <7h8ul1x86o.fsf@deeprootsystems.com> References: <1411779495-39724-1-git-send-email-lina.iyer@linaro.org> <1411779495-39724-6-git-send-email-lina.iyer@linaro.org> <20140929153154.GF2165@e102568-lin.cambridge.arm.com> <7hmw9hypj9.fsf@deeprootsystems.com> <7h8ul1x86o.fsf@deeprootsystems.com> Message-ID: <20140930203652.GE528@ilina-mac.local> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Tue, Sep 30 2014 at 12:41 -0600, Kevin Hilman wrote: >Nicolas Pitre writes: > >> On Tue, 30 Sep 2014, Kevin Hilman wrote: >> >>> On Tue, Sep 30, 2014 at 10:51 AM, Nicolas Pitre >>> wrote: >>> > On Tue, 30 Sep 2014, Kevin Hilman wrote: >>> > >>> >> Lorenzo Pieralisi writes: > >[...] > >>> >> > This may be misleading. Call it PlatformWFI or something like that, not WFI if >>> >> > that's not what it is. >>> >> >>> >> This gets at a little pet peeve of mine: >>> >> >>> >> IMO, naming any state with "WFI" is a bit confusing, because typically >>> >> *every* idle state is entered by one (or more) CPU executing WFI, no? >>> > >>> > Agreed. >>> > >>> > The only state called "WFI" should be the one that only executes the WFI >>> > instruction without any other hardware setup around it. >>> >>> Well, I would go even further in that none of the states should be >>> called WFI, because WFI is used to enter all of them. >> >> Fair enough. >> >> So let's fix this by finding a name for that state that consists of only >> executing WFI and that every SOC has. >> >> Suggestions? > >The DT idle-states binding doc (though seemingly written more with >arm64 and SBSA in mind) uses "standby" for the shallowest idle. > Standby - looks good to me.