From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jean-Francois Moine Subject: Re: [PATCH] ASoC:kirkwood: Don't raise an error when no DAI format Date: Wed, 1 Oct 2014 10:59:39 +0200 Message-ID: <20141001105939.1f2b6524@armhf> References: <20140928150342.CC21B786A1D@smtpfb1-g21.free.fr> <20140928151207.GI5182@n2100.arm.linux.org.uk> <20140928180550.5f0b8f03@armhf> <20140930181910.GJ4273@sirena.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from smtp4-g21.free.fr (smtp4-g21.free.fr [212.27.42.4]) by alsa0.perex.cz (Postfix) with ESMTP id 87E9E260472 for ; Wed, 1 Oct 2014 10:59:25 +0200 (CEST) In-Reply-To: <20140930181910.GJ4273@sirena.org.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: Mark Brown Cc: alsa-devel@alsa-project.org, Russell King - ARM Linux , linux-kernel@vger.kernel.org List-Id: alsa-devel@alsa-project.org T24gVHVlLCAzMCBTZXAgMjAxNCAxOToxOToxMCArMDEwMApNYXJrIEJyb3duIDxicm9vbmllQGtl cm5lbC5vcmc+IHdyb3RlOgoKPiBPbiBTdW4sIFNlcCAyOCwgMjAxNCBhdCAwNjowNTo1MFBNICsw MjAwLCBKZWFuLUZyYW5jb2lzIE1vaW5lIHdyb3RlOgo+ID4gUnVzc2VsbCBLaW5nIC0gQVJNIExp bnV4IDxsaW51eEBhcm0ubGludXgub3JnLnVrPiB3cm90ZToKPiA+ID4gT24gU3VuLCBTZXAgMjgs IDIwMTQgYXQgMDQ6MTk6MjdQTSArMDIwMCwgSmVhbi1GcmFuY29pcyBNb2luZSB3cm90ZToKPiAK PiA+ID4gPiBUaGlzIHBhdGNoIHByZXZlbnRzIHRoZSBjb250cm9sbGVyIHRvIHJhaXNlIGFuIGVy cm9yIHdoZW4KPiA+ID4gPiB0aGUgRFQgYXVkaW8gY2FyZCBkZWZpbml0aW9uIGJ5IHRoZSBzaW1w bGUgY2FyZCBjb250YWlucyB0aGUgUENNCj4gPiA+ID4gZm9ybWF0IG9mIG9uZSBDUFUgREFJIG9u bHkuCj4gCj4gPiA+IEkgdGhpbmsgdGhpcyBpcyBhIHNpbGx5IGlkZWEgLSB3aHkgc2hvdWxkIGV2 ZXJ5IGRyaXZlciBoYXZlIGFkZGl0aW9uYWwgY29kZQo+ID4gPiB0byBkZXRlY3Qgd2hlbiBpdCdz IGNhbGxlZCB0byBkbyB0aGluZy4gIFdoeSBkb2Vzbid0IHRoZSBzaW1wbGUgY2FyZCBjb2RlCj4g PiA+IGFsd2F5cyBwYXNzIHRoZSByZXF1aXJlZCBmb3JtYXQ/Cj4gCj4gPiA+IExvb2tpbmcgYXQg b3RoZXIgZHJpdmVycywgbm8gb25lIGVsc2UgZG9lcyB0aGlzOyB0aGV5IGFsbCBhcHBlYXIgdG8g cmVxdWlyZQo+ID4gPiB0aGUgcHJvcGVyIGZvcm1hdCB0byBiZSBzcGVjaWZpZWQuCj4gCj4gPiA+ IFdoYXQgc29tZSBkcml2ZXJzIGRvIChlZywgb21hcC1tY2JzcC5jKSBpcyB0byBibG9jayBzZXRf Zm10IHdoZW4gdGhlCj4gPiA+IERBSSBpcyBhbHJlYWR5IGluIHVzZSAtIHNldHRpbmcgYSBmbGFn ICJjb25maWd1cmVkIiBpbiBod19wYXJhbXMsIGFuZAo+ID4gPiBjbGVhcmluZyBpdCBpbiBzaHV0 ZG93bi4gIE1heWJlIGZvbGxvd2luZyB0aGlzIHdpbGwgc29sdmUgeW91ciBwcm9ibGVtLgo+IAo+ ID4gPiBJbiBhbnkgY2FzZSwgcmFuZG9tIGRyaXZlcnMgZG9pbmcgc3R1ZmYgZGlmZmVyZW50bHkg d2l0aG91dCByZWFzb24gaXMKPiA+ID4gcmVhbGx5IG5vdCBhIGdvb2QgaWRlYS4KPiAKPiA+IEFz IHRoZSBzaW1wbGUgY2FyZCBpcyBkb25lLCB0aGUgYXVkaW8gaGFyZHdhcmUgZGVmaW5pdGlvbnMg b2YgdGhlCj4gPiBwbGF0Zm9ybSBhbmQgYWxsIHRoZSBDUFUgREFJUyBhcmUgYWx3YXlzIHNldCBp biB0aGUgYXVkaW8gY29udHJvbGxlci4KPiAKPiA+IFdoZW4gdGhlIFBDTSBmb3JtYXQgaXMgZ2xv YmFsbHkgZGVmaW5lZCAocGxhdGZvcm0pLCB0aGUgZnVuY3Rpb24KPiA+IHNldF9mbXQoKSBpcyBj YWxsZWQgZm9yIGFsbCBDUFUgREFJcyAodGhlbiwgdHdpY2UgZm9yIHRoZSBraXJrd29vZAo+ID4g Y29udHJvbGxlcikgd2l0aCB0aGUgc2FtZSB2YWx1ZS4gVGhlIERUIGlzOgo+IAo+IC4uLgo+IAo+ ID4gVGhlIFBDTSBmb3JtYXQgbWF5IGFsc28gYmUgZGVmaW5lZCBwZXIgREFJIGxpbmsuIFRoZSBm b2xsb3dpbmcgRFQgd29ya3MKPiA+IHRoZSBzYW1lIGFzIHNldHRpbmcgZ2xvYmFsbHkgdGhlIGZv cm1hdCwgaS5lLiB0aGVyZSBhcmUgdHdvIGNhbGxzIHRvCj4gPiBzZXRfZm10KCkgd2l0aCAnaTJz JzoKPiAKPiA+IFRoZSBwcm9ibGVtIGFwcGVhcnMgd2hlbiB0aGUgZm9ybWF0IGlzIGRlZmluZWQg aW4gb25seSBvbmUgREFJIGxpbms6Cj4gCj4gPiBUaGVuLCBhdWRpbyBkb2VzIG5vdCB3b3JrLgo+ IAo+IFNvIHRoaXMgaXMgc3RpbGwgYSBnZW5lcmljIHJhdGhlciB0aGFuIGRyaXZlciBpc3N1ZSBh bmQgc2hvdWxkIGJlIHNvbHZlZAo+IG91dHNpZGUgb2YgdGhlIGRyaXZlciAtIGV4YWN0bHkgdGhl IHNhbWUgaXNzdWUgaXMgZ29pbmcgdG8gYXBwbHkgdG8gYW55Cj4gb3RoZXIgZGV2aWNlIHdpdGgg YSBzaW1pbGFyIHNoYXJlZCBjb25maWd1cmF0aW9uLiAgV2UgY291bGQgZWl0aGVyIHNheQo+IHRo YXQgdGhlIERUIGlzIGJ1Z2d5IGhlcmUgb3Igd2UgY291bGQgc2F5IHRoYXQgdGhlIGdlbmVyaWMg Y2FyZCBvdWdodCB0bwo+IGFzc3VtZSB0aGF0IGlmIG9ubHkgb25lIGxpbmsgc3BlY2lmaWVzIGEg Zm9ybWF0IHRoZW4gaXQgc2hvdWxkIHVzZSB0aGF0Cj4gZm9ybWF0IGZvciBvdGhlciBsaW5rcyBp ZiBwb3NzaWJsZSAoc2luY2UgY2xlYXJseSB0aGUgdXNlciBkb2Vzbid0IGNhcmUKPiB3aGF0IGl0 IGNob29zZXMpLgoKVGhlICdkYWlmbXQnIG9mIHRoZSBjYWxsYmFjayBmdW5jdGlvbiBzZXRfZm10 IChzbmRfc29jX2RhaV9zZXRfZm10KQpjb250YWlucyA0IHBhcnRzOgotIHRoZSBwaHlzaWNhbCBm b3JtYXQsCi0gdGhlIGNsb2NrIGdhdGluZywKLSB0aGUgc2lnbmFsIGludmVyc2lvbnMsCi0gdGhl IG1hc3RlciBjbG9jayBkZWZpbml0aW9ucy4KCkFzIHRoZSB2YWx1ZSAnMCcgaXMgbm90IHVzZWQg aW4gdGhlIHBoeXNpY2FsIGZvcm1hdCBub3IgaW4gdGhlIG1hc3RlcgpjbG9jaywgdGhpcyB2YWx1 ZSB3b3VsZCBoYXZlIHNheSAnZG9uJ3QgY2hhbmdlJywgcGVybWl0dGluZyB0aGUKcGFyYW1ldGVy cyB0byBiZSBzZXQgaW5kZXBlbmRlbnRseS4KCkJ1dCwgYXMgeW91IGFuZCBSdXNzZWxsIHNheSAn bm8nLCBJIHdpbGwgbGV0IHRoZSBmb3JtYXQgZGVmaW5pdGlvbiBhdAp0aGUgcGxhdGZvcm0gbGV2 ZWwgaW4gdGhlIERULiBTZXR0aW5nIHR3aWNlIHRoZSBoYXJkd2FyZSByZWdpc3RlcnMgaXMKbm90 IGEgcHJvYmxlbS4KClRoYW5rcy4KCj4gUGxlYXNlIGFsc28gdHJ5IHRvIHVzZSBzdWJqZWN0IGxp bmVzIG1hdGNoaW5nIHRoZSBzdHlsZSBmb3IgdGhlCj4gc3Vic3lzdGVtLiAgWW91J3ZlIGJlZW4g d29ya2luZyB3aXRoIHVwc3RyZWFtIGZvciBhIHdoaWxlLCB5b3UgcmVhbGx5Cj4gb3VnaHQgdG8g YmUgZmFtaWxpYXIgd2l0aCB0aGlzIHNvcnQgb2YgYmFzaWMgcHJvY2VzcyBzdHVmZi4KClNvcnJ5 LgoKLS0gCktlbiBhciBjJ2hlbnRhw7EJfAkgICAgICAqKiBCcmVpemggaGEgTGludXggYXRhdiEg KioKSmVmCQl8CQlodHRwOi8vbW9pbmVqZi5mcmVlLmZyLwpfX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fXwpBbHNhLWRldmVsIG1haWxpbmcgbGlzdApBbHNhLWRl dmVsQGFsc2EtcHJvamVjdC5vcmcKaHR0cDovL21haWxtYW4uYWxzYS1wcm9qZWN0Lm9yZy9tYWls bWFuL2xpc3RpbmZvL2Fsc2EtZGV2ZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751986AbaJAI7b (ORCPT ); Wed, 1 Oct 2014 04:59:31 -0400 Received: from smtp4-g21.free.fr ([212.27.42.4]:4222 "EHLO smtp4-g21.free.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751676AbaJAI71 convert rfc822-to-8bit (ORCPT ); Wed, 1 Oct 2014 04:59:27 -0400 Date: Wed, 1 Oct 2014 10:59:39 +0200 From: Jean-Francois Moine To: Mark Brown Cc: Russell King - ARM Linux , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ASoC:kirkwood: Don't raise an error when no DAI format Message-ID: <20141001105939.1f2b6524@armhf> In-Reply-To: <20140930181910.GJ4273@sirena.org.uk> References: <20140928150342.CC21B786A1D@smtpfb1-g21.free.fr> <20140928151207.GI5182@n2100.arm.linux.org.uk> <20140928180550.5f0b8f03@armhf> <20140930181910.GJ4273@sirena.org.uk> X-Mailer: Claws Mail 3.10.1 (GTK+ 2.24.24; arm-unknown-linux-gnueabihf) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 30 Sep 2014 19:19:10 +0100 Mark Brown wrote: > On Sun, Sep 28, 2014 at 06:05:50PM +0200, Jean-Francois Moine wrote: > > Russell King - ARM Linux wrote: > > > On Sun, Sep 28, 2014 at 04:19:27PM +0200, Jean-Francois Moine wrote: > > > > > This patch prevents the controller to raise an error when > > > > the DT audio card definition by the simple card contains the PCM > > > > format of one CPU DAI only. > > > > I think this is a silly idea - why should every driver have additional code > > > to detect when it's called to do thing. Why doesn't the simple card code > > > always pass the required format? > > > > Looking at other drivers, no one else does this; they all appear to require > > > the proper format to be specified. > > > > What some drivers do (eg, omap-mcbsp.c) is to block set_fmt when the > > > DAI is already in use - setting a flag "configured" in hw_params, and > > > clearing it in shutdown. Maybe following this will solve your problem. > > > > In any case, random drivers doing stuff differently without reason is > > > really not a good idea. > > > As the simple card is done, the audio hardware definitions of the > > platform and all the CPU DAIS are always set in the audio controller. > > > When the PCM format is globally defined (platform), the function > > set_fmt() is called for all CPU DAIs (then, twice for the kirkwood > > controller) with the same value. The DT is: > > ... > > > The PCM format may also be defined per DAI link. The following DT works > > the same as setting globally the format, i.e. there are two calls to > > set_fmt() with 'i2s': > > > The problem appears when the format is defined in only one DAI link: > > > Then, audio does not work. > > So this is still a generic rather than driver issue and should be solved > outside of the driver - exactly the same issue is going to apply to any > other device with a similar shared configuration. We could either say > that the DT is buggy here or we could say that the generic card ought to > assume that if only one link specifies a format then it should use that > format for other links if possible (since clearly the user doesn't care > what it chooses). The 'daifmt' of the callback function set_fmt (snd_soc_dai_set_fmt) contains 4 parts: - the physical format, - the clock gating, - the signal inversions, - the master clock definitions. As the value '0' is not used in the physical format nor in the master clock, this value would have say 'don't change', permitting the parameters to be set independently. But, as you and Russell say 'no', I will let the format definition at the platform level in the DT. Setting twice the hardware registers is not a problem. Thanks. > Please also try to use subject lines matching the style for the > subsystem. You've been working with upstream for a while, you really > ought to be familiar with this sort of basic process stuff. Sorry. -- Ken ar c'hentañ | ** Breizh ha Linux atav! ** Jef | http://moinejf.free.fr/