From: Mark Brown <broonie@kernel.org>
To: Lars-Peter Clausen <lars@metafoo.de>
Cc: Dan Murphy <dmurphy@ti.com>,
gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org,
linux-omap@vger.kernel.org
Subject: Re: [PATCH] regmap: Allow read_reg_mask to be 0
Date: Wed, 1 Oct 2014 12:15:04 +0100 [thread overview]
Message-ID: <20141001111504.GR4273@sirena.org.uk> (raw)
In-Reply-To: <542B20BE.3060200@metafoo.de>
[-- Attachment #1: Type: text/plain, Size: 1029 bytes --]
On Tue, Sep 30, 2014 at 11:29:34PM +0200, Lars-Peter Clausen wrote:
> On 09/30/2014 11:18 PM, Dan Murphy wrote:
Dan, please fix your mail client to word wrap within paragraphs.
> >The device, which is already in production, has a specific control register that sets either the reading or writing of the rest of the registers.
> >Here is the data sheet
> >http://www.ti.com/lit/ds/symlink/afe4403.pdf
> >See page 61 control0.
> >Driver is written for this part just want to get this lead patch in or maybe an alternate solution.
> Looking at this the generic SPI regmap implementation might not necessarily
> be the best thing to use here and you are probably better of implementing
> either your own regmap bus or reg_read/reg_write callbacks that
> automatically set/clear the SPI_READ bit in the control register depending
> on the operation.
It definitely needs more than just this change at any rate - any generic
infrastructure that tries to work with the regmap is not going to know
about this read/write register.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
next prev parent reply other threads:[~2014-10-01 11:15 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-30 16:07 [PATCH] regmap: Allow read_reg_mask to be 0 Dan Murphy
2014-09-30 16:07 ` Dan Murphy
2014-09-30 17:25 ` Mark Brown
2014-09-30 20:19 ` Dan Murphy
2014-09-30 20:19 ` Dan Murphy
2014-09-30 20:20 ` Dan Murphy
2014-09-30 20:20 ` Dan Murphy
2014-09-30 20:39 ` Dan Murphy
2014-09-30 20:39 ` Dan Murphy
2014-09-30 21:03 ` Lars-Peter Clausen
2014-09-30 21:18 ` Dan Murphy
2014-09-30 21:18 ` Dan Murphy
2014-09-30 21:29 ` Lars-Peter Clausen
2014-10-01 11:15 ` Mark Brown [this message]
2014-10-01 11:39 ` Dan Murphy
2014-10-01 11:39 ` Dan Murphy
2014-10-01 16:30 ` Lars-Peter Clausen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141001111504.GR4273@sirena.org.uk \
--to=broonie@kernel.org \
--cc=dmurphy@ti.com \
--cc=gregkh@linuxfoundation.org \
--cc=lars@metafoo.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.