From: Borislav Petkov <bp@alien8.de>
To: Aravind Gopalakrishnan <aravind.gopalakrishnan@amd.com>
Cc: bhelgaas@google.com, linux-pci@vger.kernel.org,
tglx@linutronix.de, hpa@zytor.com, x86@kernel.org, bp@suse.de,
dan.carpenter@oracle.com, dougthompson@xmission.com,
m.chehab@samsung.com, linux-edac@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4/4] edac, amd64_edac: Add F15h M60h support
Date: Wed, 1 Oct 2014 17:45:24 +0200 [thread overview]
Message-ID: <20141001154523.GF18271@pd.tnic> (raw)
In-Reply-To: <542C1EAA.4050408@amd.com>
On Wed, Oct 01, 2014 at 10:32:58AM -0500, Aravind Gopalakrishnan wrote:
> >>+ if (dcsm & 0x3) {
> >>+ /* LRDIMMs */
> >>+ edac_dbg(1, " DIMM type: LRDIMM %dx rank multiply;"
> >>+ "CS = %d; all DIMMs support ECC: %s\n",
> >>+ (dcsm & 0x3), cs,
> >>+ (dclr & BIT(19)) ? "yes" : "no");
> >Why do we need to iterate over the DRAM CS sets? Just for the rank
> >multiplier, apparently. We dump those normally in read_dct_base_mask(),
> >though.
>
> It's not just for rank multiplier.. we find that it's LRDIMM only by
> examining dcsm. Hence the iteration here..
So we can look only at the first DCSM, no? Or are there systems with
different types of LRDIMMs on one DCT?
--
Regards/Gruss,
Boris.
Sent from a fat crate under my desk. Formatting is fine.
--
next prev parent reply other threads:[~2014-10-01 15:45 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-18 19:57 [PATCH 4/4] edac, amd64_edac: Add F15h M60h support Aravind Gopalakrishnan
2014-10-01 11:32 ` Borislav Petkov
2014-10-01 15:32 ` Aravind Gopalakrishnan
2014-10-01 15:45 ` Borislav Petkov [this message]
2014-10-01 16:02 ` Aravind Gopalakrishnan
2014-10-01 16:11 ` Borislav Petkov
2014-10-03 14:39 ` Aravind Gopalakrishnan
2014-10-06 21:11 ` Borislav Petkov
2014-10-01 19:44 ` Aravind Gopalakrishnan
2014-10-02 14:52 ` Borislav Petkov
2014-10-02 15:23 ` Aravind Gopalakrishnan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141001154523.GF18271@pd.tnic \
--to=bp@alien8.de \
--cc=aravind.gopalakrishnan@amd.com \
--cc=bhelgaas@google.com \
--cc=bp@suse.de \
--cc=dan.carpenter@oracle.com \
--cc=dougthompson@xmission.com \
--cc=hpa@zytor.com \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=m.chehab@samsung.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.