From: Mike Snitzer <snitzer@redhat.com>
To: Mikulas Patocka <mpatocka@redhat.com>
Cc: dm-devel@redhat.com, Edward Thornber <thornber@redhat.com>,
"Alasdair G. Kergon" <agk@redhat.com>
Subject: Re: dm-bufio: break out of both loops when freeing data
Date: Wed, 1 Oct 2014 14:42:31 -0400 [thread overview]
Message-ID: <20141001184231.GA13947@redhat.com> (raw)
In-Reply-To: <alpine.LRH.2.02.1410011334210.25573@file01.intranet.prod.int.rdu2.redhat.com>
On Wed, Oct 01 2014 at 1:35pm -0400,
Mikulas Patocka <mpatocka@redhat.com> wrote:
>
>
> On Wed, 1 Oct 2014, Mikulas Patocka wrote:
>
> > When we free the required number of entries (nr_to_scan becomes zero), we
> > must break out of both loops. The code exited only the inner loop and
> > continued in the outer loop.
> >
> > Also, move dm_bufio_cond_resched to the inner loop, so that scanning the
> > list doesn't result in scheduling latency.
> >
> > Signed-off-by: Mikulas Patocka <mpatocka@redhat.com>
>
> I forgot to add:
>
> Cc: stable@vger.kernel.org # 3.2+
I tweaked the header, used a return rather than goto, and staged in
linux-next for 3.18. See:
https://git.kernel.org/cgit/linux/kernel/git/device-mapper/linux-dm.git/commit/?h=for-next&id=04c308f43a90a9b3b84c344b324d6af29288da05
prev parent reply other threads:[~2014-10-01 18:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-01 17:29 [PATCH] dm-bufio: break out of both loops when freeing data Mikulas Patocka
2014-10-01 17:35 ` Mikulas Patocka
2014-10-01 18:42 ` Mike Snitzer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141001184231.GA13947@redhat.com \
--to=snitzer@redhat.com \
--cc=agk@redhat.com \
--cc=dm-devel@redhat.com \
--cc=mpatocka@redhat.com \
--cc=thornber@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.