All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] librtlsdr: disable shared library target
Date: Wed, 1 Oct 2014 19:20:20 +0200	[thread overview]
Message-ID: <20141001192020.71ec3c36@free-electrons.com> (raw)
In-Reply-To: <CAHXCMMJjZ3BmockfvRQaWJeccOG_+Zth=ewTK7WWQz-A_5HXyQ@mail.gmail.com>

Dear Samuel Martin,

On Sun, 28 Sep 2014 13:51:25 +0200, Samuel Martin wrote:

> > Thanks, but we already have a patch fixing the same issue in our patch
> > queue, see http://patchwork.ozlabs.org/patch/384567/. Apparently, the
> > patch is causing some issues.
> >
> > Samuel, what is your plan regarding librtlsdr static link issue?
> 
> The patch added with this pathc is similar to the 2nd patch added in
> http://patchwork.ozlabs.org/patch/384567/.
> 
> In http://patchwork.ozlabs.org/patch/384567/, the first patch is
> causing some issue.
> After checking the libusb dependencies, this first patch is not needed
> in the context of Buildroot because when BR2_PREFER_STATIC_LIBS=y,
> libusb won't depend on any library.
> 
> IMO, this patch can be merged as is, and
> http://patchwork.ozlabs.org/patch/384567/ can be marked as superseded.

Thanks for the explanation. Next time, could you add your
formal Reviewed-by, Acked-by or Tested-by?

Thanks,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

  reply	other threads:[~2014-10-01 17:20 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-24 12:31 [Buildroot] [PATCH] librtlsdr: disable shared library target Yuvaraj Patil
2014-09-24 13:33 ` Thomas Petazzoni
2014-09-28 11:51   ` Samuel Martin
2014-10-01 17:20     ` Thomas Petazzoni [this message]
2014-10-01 17:19 ` Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141001192020.71ec3c36@free-electrons.com \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.