From: Dave Chinner <david@fromorbit.com>
To: Brian Foster <bfoster@redhat.com>
Cc: iusty@k1024.org, xfs@oss.sgi.com
Subject: Re: [PATCH 2/2] xfs: only set extent size hint when asked
Date: Thu, 2 Oct 2014 09:21:26 +1000 [thread overview]
Message-ID: <20141001232126.GE10298@dastard> (raw)
In-Reply-To: <20141001115959.GB53779@bfoster.bfoster>
On Wed, Oct 01, 2014 at 07:59:59AM -0400, Brian Foster wrote:
> On Tue, Sep 30, 2014 at 11:46:05AM +1000, Dave Chinner wrote:
> > From: Dave Chinner <dchinner@redhat.com>
> >
> > Currently the extent size hint is set unconditionally in
> > xfs_ioctl_setattr(), even when the FSX_EXTSIZE flag is not set. This
> > means we can set values from uninitialised stack variables. Hence
> > only set the extent size hint from userspace when both the mask
> > falg is set and the inode has the XFS_DIFLAG_EXTSIZE flag set to
> > indicate that we should have an extent size hint set on the inode.
> >
>
> I'm not sure what you mean here by FSX_EXTSIZE not being checked. It
> looks like FSX_EXTSIZE is checked before and after the patch.
Yup, I wrote the commit message, then did the fix and forgot to
update the message after I realised it was wrong. I've fixed the
commit message.
> Regardless, the fix looks Ok to me...
>
> Reviewed-by: Brian Foster <bfoster@redhat.com>
Thanks!
-Dave.
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2014-10-01 23:21 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-30 1:46 [PATCH 0/2] xfs: cleanup XFS_IOC_SETXATTR behaviour Dave Chinner
2014-09-30 1:46 ` [PATCH 1/2] xfs: project id inheritance is a directory only flag Dave Chinner
2014-10-01 11:58 ` Brian Foster
2014-09-30 1:46 ` [PATCH 2/2] xfs: only set extent size hint when asked Dave Chinner
2014-09-30 5:58 ` Iustin Pop
2014-09-30 22:13 ` Dave Chinner
2014-10-01 11:59 ` Brian Foster
2014-10-01 23:21 ` Dave Chinner [this message]
2014-09-30 5:55 ` [PATCH 0/2] xfs: cleanup XFS_IOC_SETXATTR behaviour Iustin Pop
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141001232126.GE10298@dastard \
--to=david@fromorbit.com \
--cc=bfoster@redhat.com \
--cc=iusty@k1024.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.