From: Dave Chinner <david@fromorbit.com>
To: Eric Sandeen <sandeen@redhat.com>
Cc: xfs-oss <xfs@oss.sgi.com>
Subject: Re: [PATCH] xfs: check for null dquot in xfs_quota_calc_throttle()
Date: Thu, 2 Oct 2014 09:25:59 +1000 [thread overview]
Message-ID: <20141001232559.GG10298@dastard> (raw)
In-Reply-To: <542C28E5.506@redhat.com>
On Wed, Oct 01, 2014 at 11:16:37AM -0500, Eric Sandeen wrote:
> Coverity spotted this.
>
> Granted, we *just* checked xfs_inod_dquot() in the caller (by calling
> xfs_quota_need_throttle), but to be honest I don't know if this can
> race, and this is the only place we don't check the return value -
> and the check seems cheap and future-proof.
>
> Signed-off-by: Eric Sandeen <sandeen@redhat.com>
> ---
>
> Sorry for the handwavy commit log, if it's obvious that it can
> race, feel free to fix the description. ;)
Description changed simply to say:
... this is the only place we don't check the return value, but the
check is cheap and future-proof, so add it.
And so:
Reviewed-by: Dave Chinner <dchinner@redhat.com>
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
prev parent reply other threads:[~2014-10-01 23:26 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-01 16:16 [PATCH] xfs: check for null dquot in xfs_quota_calc_throttle() Eric Sandeen
2014-10-01 23:25 ` Dave Chinner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141001232559.GG10298@dastard \
--to=david@fromorbit.com \
--cc=sandeen@redhat.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.