From: Peter Zijlstra <peterz@infradead.org>
To: Kirill Tkhai <ktkhai@parallels.com>
Cc: Sasha Levin <sasha.levin@oracle.com>,
mingo@kernel.org, torvalds@linux-foundation.org,
paulmck@linux.vnet.ibm.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] sched: Use RCU read lock on all calls to dl_bw_of()
Date: Thu, 2 Oct 2014 11:24:28 +0200 [thread overview]
Message-ID: <20141002092428.GA2849@worktop.programming.kicks-ass.net> (raw)
In-Reply-To: <1412065417.20287.24.camel@tkhai>
On Tue, Sep 30, 2014 at 12:23:37PM +0400, Kirill Tkhai wrote:
> [PATCH]sched: Use dl_bw_of() under preempt_disable()
>
> rq->rd is freed using call_rcu_sched(), so rcu_read_lock() to access it
> is not enough. We should use either rcu_read_lock_sched() or preempt_disable().
>
> We choose preempt_disable()/preempt_enable() like in other places
> where rq->rd is used.
I changed it to rcu_read_lock_sched(), but no biggie, thanks!
next prev parent reply other threads:[~2014-10-02 9:24 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-29 15:19 [PATCH] sched: Use RCU read lock on all calls to dl_bw_of() Sasha Levin
2014-09-29 16:43 ` Kirill Tkhai
2014-09-29 16:54 ` Peter Zijlstra
2014-09-29 17:00 ` Peter Zijlstra
2014-09-30 8:23 ` Kirill Tkhai
2014-10-02 9:24 ` Peter Zijlstra [this message]
2014-10-03 5:28 ` [tip:sched/core] sched/dl: Use dl_bw_of() under rcu_read_lock_sched() tip-bot for Kirill Tkhai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141002092428.GA2849@worktop.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=ktkhai@parallels.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=paulmck@linux.vnet.ibm.com \
--cc=sasha.levin@oracle.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.