From: Chao Peng <chao.p.peng@linux.intel.com>
To: Jan Beulich <JBeulich@suse.com>
Cc: keir@xen.org, Ian.Campbell@citrix.com,
stefano.stabellini@eu.citrix.com, George.Dunlap@eu.citrix.com,
andrew.cooper3@citrix.com, Ian.Jackson@eu.citrix.com,
xen-devel@lists.xen.org, dgdegra@tycho.nsa.gov
Subject: Re: [PATCH v18 08/10] x86: add CMT related MSRs in allowed list
Date: Thu, 2 Oct 2014 18:27:17 +0800 [thread overview]
Message-ID: <20141002102717.GB12435@pengc-linux> (raw)
In-Reply-To: <542BFED9020000780003B832@mail.emea.novell.com>
On Wed, Oct 01, 2014 at 12:17:13PM +0100, Jan Beulich wrote:
> >>> On 01.10.14 at 12:59, <chao.p.peng@linux.intel.com> wrote:
> > On Tue, Sep 30, 2014 at 02:26:35PM +0100, Jan Beulich wrote:
> >> >>> On 30.09.14 at 12:49, <chao.p.peng@linux.intel.com> wrote:
> >> > --- a/xen/include/asm-x86/msr-index.h
> >> > +++ b/xen/include/asm-x86/msr-index.h
> >> > @@ -324,6 +324,8 @@
> >> > #define MSR_IA32_ENERGY_PERF_BIAS 0x000001b0
> >> >
> >> > /* Platform Shared Resource MSRs */
> >> > +#define MSR_IA32_QOSEVTSEL 0x00000c8d
> >>
> >> Is this still an appropriate name with then name change "QOS" -> "CMT"?
> >>
> >> > +#define MSR_IA32_QMC 0x00000c8e
> >>
> >> The Q here may similarly be questionable now.
> >>
> >> > #define MSR_IA32_PQR_ASSOC 0x00000c8f
> >>
> >> And maybe even the one here?
> >>
> >>
> >
> > As the SDM still use the old names, I left these names unchanged so that
> > no surprise for someone don't know the history to look into the spec.
> >
> > So it's more like a spec issue.
> >
> > On the other hand, I also feel the code here looks ugly. So maybe we can
> > still change them to 'correct' ones?
>
> If you can first internally agree on stable names going forward?
Yes, I'm pushing for this.
Chao
next prev parent reply other threads:[~2014-10-02 10:27 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-30 10:49 [PATCH v18 00/10] enable Cache Monitoring Technology (CMT) feature Chao Peng
2014-09-30 10:49 ` [PATCH v18 01/10] x86: add generic resource (e.g. MSR) access hypercall Chao Peng
2014-09-30 11:00 ` Andrew Cooper
2014-09-30 11:08 ` Andrew Cooper
2014-09-30 12:15 ` Jan Beulich
2014-09-30 12:12 ` Jan Beulich
2014-10-01 10:04 ` Chao Peng
2014-10-01 10:33 ` Jan Beulich
2014-10-02 10:26 ` Chao Peng
2014-09-30 10:49 ` [PATCH v18 02/10] xsm: add resource operation related xsm policy Chao Peng
2014-09-30 10:49 ` [PATCH v18 03/10] tools: provide interface for generic resource access Chao Peng
2014-09-30 10:49 ` [PATCH v18 04/10] x86: detect and initialize Cache Monitoring Technology feature Chao Peng
2014-09-30 13:13 ` Jan Beulich
2014-10-01 10:49 ` Chao Peng
2014-09-30 10:49 ` [PATCH v18 05/10] x86: dynamically attach/detach CMT service for a guest Chao Peng
2014-09-30 10:49 ` [PATCH v18 06/10] x86: collect global CMT information Chao Peng
2014-09-30 13:20 ` Jan Beulich
2014-09-30 10:49 ` [PATCH v18 07/10] x86: enable CMT for each domain RMID Chao Peng
2014-09-30 10:49 ` [PATCH v18 08/10] x86: add CMT related MSRs in allowed list Chao Peng
2014-09-30 13:26 ` Jan Beulich
2014-10-01 10:59 ` Chao Peng
2014-10-01 11:17 ` Jan Beulich
2014-10-02 10:27 ` Chao Peng [this message]
2014-10-06 14:01 ` Chao Peng
2014-10-06 14:06 ` Andrew Cooper
2014-10-06 14:23 ` Chao Peng
2014-10-08 7:58 ` Chao Peng
2014-09-30 10:49 ` [PATCH v18 09/10] xsm: add CMT related xsm policies Chao Peng
2014-09-30 10:49 ` [PATCH v18 10/10] tools: CMDs and APIs for Cache Monitoring Technology Chao Peng
2014-10-02 14:57 ` Konrad Rzeszutek Wilk
2014-10-02 16:49 ` Wei Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141002102717.GB12435@pengc-linux \
--to=chao.p.peng@linux.intel.com \
--cc=George.Dunlap@eu.citrix.com \
--cc=Ian.Campbell@citrix.com \
--cc=Ian.Jackson@eu.citrix.com \
--cc=JBeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=dgdegra@tycho.nsa.gov \
--cc=keir@xen.org \
--cc=stefano.stabellini@eu.citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.