From: Christoph Hellwig <hch@lst.de>
To: Hannes Reinecke <hare@suse.de>
Cc: Christoph Hellwig <hch@lst.de>,
James Bottomley <jbottomley@parallels.com>,
Sagi Grimberg <sagig@dev.mellanox.co.il>,
Webb Scales <webbnh@hp.com>,
linux-scsi@vger.kernel.org
Subject: Re: [RFC PATCH 0/5] Remove scmd->tag
Date: Thu, 2 Oct 2014 13:20:30 +0200 [thread overview]
Message-ID: <20141002112030.GA31346@lst.de> (raw)
In-Reply-To: <1412246593-107001-1-git-send-email-hare@suse.de>
This seems to miss a places, that mostly just seem to use scmd->tag
where they should be using scmd->request->tag:
- acornscsi.c (and arm/queue.c)
- fas216
- qla1280
As well as virtio_scsi, which does a pointless assignment to scmd->tag.
It might be worth to push this out to somewhere where the buildbot
can find it while waiting for the NCR5380 overhaul.
prev parent reply other threads:[~2014-10-02 11:20 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-02 10:43 [RFC PATCH 0/5] Remove scmd->tag Hannes Reinecke
2014-10-02 10:43 ` [PATCH 1/5] NCR5380: Whitespace cleanup Hannes Reinecke
2014-10-02 11:07 ` Finn Thain
2014-10-02 11:12 ` Hannes Reinecke
2014-10-02 10:43 ` [PATCH 2/5] scsi: Remove references to linked commands Hannes Reinecke
2014-10-02 10:43 ` [PATCH 3/5] vmw_pvscsi: fixup tagging Hannes Reinecke
2014-10-02 10:43 ` [PATCH 4/5] tcm_loop: Fixup tag handling Hannes Reinecke
2014-10-02 10:43 ` [PATCH 5/5] scsi: Remove scmd->tag Hannes Reinecke
2014-10-02 11:22 ` Christoph Hellwig
2014-10-02 11:36 ` Hannes Reinecke
2014-10-02 11:48 ` Finn Thain
2014-10-02 11:20 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141002112030.GA31346@lst.de \
--to=hch@lst.de \
--cc=hare@suse.de \
--cc=jbottomley@parallels.com \
--cc=linux-scsi@vger.kernel.org \
--cc=sagig@dev.mellanox.co.il \
--cc=webbnh@hp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.