From: Dan Carpenter <dan.carpenter@oracle.com>
To: draviv@codeaurora.org
Cc: linux-scsi@vger.kernel.org
Subject: re: ufs: definitions for phy interface
Date: Thu, 2 Oct 2014 18:31:38 +0300 [thread overview]
Message-ID: <20141002153138.GC11534@mwanda> (raw)
Hello Dolev Raviv,
This is a semi-automatic email about new static checker warnings.
The patch e785060ea3a1: "ufs: definitions for phy interface" from Sep
25, 2014, leads to the following Smatch complaint:
drivers/scsi/ufs/ufshcd.c:5118 ufshcd_system_suspend()
error: we previously assumed 'hba' could be null (see line 5089)
drivers/scsi/ufs/ufshcd.c
5088
5089 if (!hba || !hba->is_powered)
^^^^
Existing check for NULL.
5090 goto out;
5091
[ snip ]
5115 ret = ufshcd_suspend(hba, UFS_SYSTEM_PM);
5116 out:
5117 if (!ret)
5118 hba->is_sys_suspended = true;
^^^^^^^^^^^^^^^^^^^^^
New unchecked dereference. This is a One Err Bug caused by "out" label
style error handling.
5119 return ret;
5120 }
regards,
dan carpenter
reply other threads:[~2014-10-02 15:31 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141002153138.GC11534@mwanda \
--to=dan.carpenter@oracle.com \
--cc=draviv@codeaurora.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.