From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jean-Francois Moine Subject: Re: [PATCH v6 2/2] drm/i2c:tda998x: Use the HDMI audio CODEC Date: Thu, 2 Oct 2014 19:59:51 +0200 Message-ID: <20141002195951.23dbc47d@armhf> References: <4b3d35a14461ed164956b7f5aa77b29170bc393d.1411547014.git.moinejf@free.fr> <20141001142340.GR5182@n2100.arm.linux.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20141001142340.GR5182@n2100.arm.linux.org.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Russell King - ARM Linux Cc: devicetree@vger.kernel.org, alsa-devel@alsa-project.org, Andrew Jackson , linux-kernel@vger.kernel.org, Jyri Sarha , Mark Brown , dri-devel@lists.freedesktop.org List-Id: alsa-devel@alsa-project.org T24gV2VkLCAxIE9jdCAyMDE0IDE1OjIzOjQxICswMTAwClJ1c3NlbGwgS2luZyAtIEFSTSBMaW51 eCA8bGludXhAYXJtLmxpbnV4Lm9yZy51az4gd3JvdGU6Cgo+IEkgd291bGQgcHJlZmVyIHRoaXMg c3RydWN0dXJlIHRvIHN0YXkgaGVyZSwgYXMgY29kZSBhYm92ZSB0aGlzIHBvaW50IHNob3VsZAo+ IGhhdmUgbm8gYnVzaW5lc3Mga25vd2luZyBob3cgdGhlc2UgYXJlIHBhY2thZ2VkIHRvZ2V0aGVy LiAgSSB3b3VsZCBzdWdnZXN0Cj4gZWl0aGVyOgo+IAo+IC0gbW92aW5nIHRoZSBhdWRpbyBjb2Rl YyBjb2RlIGJlbG93IHRoaXMgcG9pbnQsIG9yCj4gLSBzdG9yaW5nIHN0cnVjdCB0ZGE5OTh4X3By aXYgaW4gdGhlIGRldmljZSBwcml2YXRlIHBvaW50ZXIsIGFuZAo+ICAgY29udmVydGluZyBpdCB0 byBzdHJ1Y3QgdGRhOTk4eF9wcml2MiB2aWEgY29udGFpbmVyX29mKCkgd2hlcmUKPiAgIG5lY2Vz c2FyeSBiZWxvdyB0aGlzIHBvaW50LgoKVGhlIHNlY29uZCBvcHRpb24gc2VlbXMgZWFzaWVyIGZv ciB1c2UgYXMgYSBzbGF2ZSBlbmNvZGVyLgoKVGhhbmtzIGZvciBhbGwgeW91ciByZW1hcmtzLiBJ IHdpbGwgc2VuZCBhbiBvdGhlciB2ZXJzaW9uLgoKLS0gCktlbiBhciBjJ2hlbnRhw7EJfAkgICAg ICAqKiBCcmVpemggaGEgTGludXggYXRhdiEgKioKSmVmCQl8CQlodHRwOi8vbW9pbmVqZi5mcmVl LmZyLwpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpkcmkt ZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cDov L2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752108AbaJBR7r (ORCPT ); Thu, 2 Oct 2014 13:59:47 -0400 Received: from smtp4-g21.free.fr ([212.27.42.4]:19160 "EHLO smtp4-g21.free.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751066AbaJBR7p convert rfc822-to-8bit (ORCPT ); Thu, 2 Oct 2014 13:59:45 -0400 Date: Thu, 2 Oct 2014 19:59:51 +0200 From: Jean-Francois Moine To: Russell King - ARM Linux Cc: Mark Brown , Dave Airlie , Andrew Jackson , Jyri Sarha , alsa-devel@alsa-project.org, devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v6 2/2] drm/i2c:tda998x: Use the HDMI audio CODEC Message-ID: <20141002195951.23dbc47d@armhf> In-Reply-To: <20141001142340.GR5182@n2100.arm.linux.org.uk> References: <4b3d35a14461ed164956b7f5aa77b29170bc393d.1411547014.git.moinejf@free.fr> <20141001142340.GR5182@n2100.arm.linux.org.uk> X-Mailer: Claws Mail 3.10.1 (GTK+ 2.24.24; arm-unknown-linux-gnueabihf) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 1 Oct 2014 15:23:41 +0100 Russell King - ARM Linux wrote: > I would prefer this structure to stay here, as code above this point should > have no business knowing how these are packaged together. I would suggest > either: > > - moving the audio codec code below this point, or > - storing struct tda998x_priv in the device private pointer, and > converting it to struct tda998x_priv2 via container_of() where > necessary below this point. The second option seems easier for use as a slave encoder. Thanks for all your remarks. I will send an other version. -- Ken ar c'hentañ | ** Breizh ha Linux atav! ** Jef | http://moinejf.free.fr/