From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jean-Francois Moine Subject: Re: [PATCH v6 2/2] drm/i2c:tda998x: Use the HDMI audio CODEC Date: Thu, 2 Oct 2014 20:37:10 +0200 Message-ID: <20141002203710.03e035f1@armhf> References: <4b3d35a14461ed164956b7f5aa77b29170bc393d.1411547014.git.moinejf@free.fr> <542C0A2C.6010802@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <542C0A2C.6010802@ti.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Jyri Sarha Cc: devicetree@vger.kernel.org, alsa-devel@alsa-project.org, Russell King - ARM Linux , Andrew Jackson , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Mark Brown List-Id: alsa-devel@alsa-project.org T24gV2VkLCAxIE9jdCAyMDE0IDE3OjA1OjMyICswMzAwCkp5cmkgU2FyaGEgPGpzYXJoYUB0aS5j b20+IHdyb3RlOgoKPiA+ICAgCWNhc2UgQUZNVF9JMlM6Cj4gID4gICAJCXJlZ193cml0ZShwcml2 LCBSRUdfTVVYX0FQLCBNVVhfQVBfU0VMRUNUX0kyUyk7Cj4gID4gICAJCWNsa3NlbF9haXAgPSBB SVBfQ0xLU0VMX0FJUF9JMlM7Cj4gID4gICAJCWNsa3NlbF9mcyA9IEFJUF9DTEtTRUxfRlNfQUNM SzsKPiAgPiAtCQljdHNfbiA9IENUU19OX00oMykgfCBDVFNfTl9LKDMpOwo+ICA+ICsKPiAgPiAr CQkvKiB3aXRoIEkyUyBpbnB1dCwgdGhlIENUU19OIHByZWRpdmlkZXIgZGVwZW5kcyBvbgo+ICA+ ICsJCSAqIHRoZSBzYW1wbGUgd2lkdGggKi8KPiAgPiArCQlzd2l0Y2ggKHByaXYtPmF1ZGlvX3Nh bXBsZV9mb3JtYXQpIHsKPiAgPiArCQljYXNlIFNORFJWX1BDTV9GT1JNQVRfUzE2X0xFOgo+ICA+ ICsJCQljdHNfbiA9IENUU19OX00oMykgfCBDVFNfTl9LKDEpOwo+ICA+ICsJCQlicmVhazsKPiAg PiArCQljYXNlIFNORFJWX1BDTV9GT1JNQVRfUzI0X0xFOgo+ICA+ICsJCQljdHNfbiA9IENUU19O X00oMykgfCBDVFNfTl9LKDIpOwo+ICA+ICsJCQlicmVhazsKPiAgPiArCQlkZWZhdWx0OiAgCj4g Cj4gU2V0dGluZyB0aGUgZGVmYXVsdCBoZXJlIGRvZXMgbm90IHJlYWxseSBoZWxwLCBiZWNhdXNl Cj4gcHJpdi0+YXVkaW9fc2FtcGxlX2Zvcm1hdCBpcyBpbml0aWFsaXplZCB0byBTTkRSVl9QQ01f Rk9STUFUX1MyNF9MRSBpbgo+IHRkYTk5OHhfZW5jb2Rlcl9zZXRfY29uZmlnKCkuIEJ1dCBJIGFt IE9rIHdpdGggdGhlIGRlZmF1bHQgYmVpbmcKPiBjaGFuZ2VkIGZvciAyNCBiaXQgc2FtcGxlcyBv biBpMnMgaW50ZXJmYWNlLgo+IAo+ICA+ICsJCWNhc2UgU05EUlZfUENNX0ZPUk1BVF9TMzJfTEU6 Cj4gID4gKwkJCWN0c19uID0gQ1RTX05fTSgzKSB8IENUU19OX0soMyk7Cj4gID4gKwkJCWJyZWFr Owo+ICA+ICsJCX0KCkkgbG9va2VkIGFnYWluIGF0IHRoZSBvcmlnaW5hbCBkcml2ZXIgYW5kIHRo ZXkgc2V0IEsgPSAxIGZvciAxNiBiaXRzCmFuZCBLID0gMyBmb3IgMjQgb3IgMzIgYml0cy4KCkFu eXdheSwgbGV0dGluZyBLID0gMyBmb3IgMTYgYml0cyB3b3JrcyBmb3IgbWUsIHNvLCBJIHdpbGwg bm90IGNoYW5nZQp0aGlzIGNvZGUgaW4gdGhlIG5leHQgdmVyc2lvbi4KClRoYW5rcy4KCi0tIApL ZW4gYXIgYydoZW50YcOxCXwJICAgICAgKiogQnJlaXpoIGhhIExpbnV4IGF0YXYhICoqCkplZgkJ fAkJaHR0cDovL21vaW5lamYuZnJlZS5mci8KX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMu ZnJlZWRlc2t0b3Aub3JnCmh0dHA6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0 aW5mby9kcmktZGV2ZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751972AbaJBShG (ORCPT ); Thu, 2 Oct 2014 14:37:06 -0400 Received: from smtp4-g21.free.fr ([212.27.42.4]:16182 "EHLO smtp4-g21.free.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751445AbaJBShD convert rfc822-to-8bit (ORCPT ); Thu, 2 Oct 2014 14:37:03 -0400 Date: Thu, 2 Oct 2014 20:37:10 +0200 From: Jean-Francois Moine To: Jyri Sarha Cc: Mark Brown , Russell King - ARM Linux , Dave Airlie , Andrew Jackson , , , , Subject: Re: [PATCH v6 2/2] drm/i2c:tda998x: Use the HDMI audio CODEC Message-ID: <20141002203710.03e035f1@armhf> In-Reply-To: <542C0A2C.6010802@ti.com> References: <4b3d35a14461ed164956b7f5aa77b29170bc393d.1411547014.git.moinejf@free.fr> <542C0A2C.6010802@ti.com> X-Mailer: Claws Mail 3.10.1 (GTK+ 2.24.24; arm-unknown-linux-gnueabihf) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 1 Oct 2014 17:05:32 +0300 Jyri Sarha wrote: > > case AFMT_I2S: > > reg_write(priv, REG_MUX_AP, MUX_AP_SELECT_I2S); > > clksel_aip = AIP_CLKSEL_AIP_I2S; > > clksel_fs = AIP_CLKSEL_FS_ACLK; > > - cts_n = CTS_N_M(3) | CTS_N_K(3); > > + > > + /* with I2S input, the CTS_N predivider depends on > > + * the sample width */ > > + switch (priv->audio_sample_format) { > > + case SNDRV_PCM_FORMAT_S16_LE: > > + cts_n = CTS_N_M(3) | CTS_N_K(1); > > + break; > > + case SNDRV_PCM_FORMAT_S24_LE: > > + cts_n = CTS_N_M(3) | CTS_N_K(2); > > + break; > > + default: > > Setting the default here does not really help, because > priv->audio_sample_format is initialized to SNDRV_PCM_FORMAT_S24_LE in > tda998x_encoder_set_config(). But I am Ok with the default being > changed for 24 bit samples on i2s interface. > > > + case SNDRV_PCM_FORMAT_S32_LE: > > + cts_n = CTS_N_M(3) | CTS_N_K(3); > > + break; > > + } I looked again at the original driver and they set K = 1 for 16 bits and K = 3 for 24 or 32 bits. Anyway, letting K = 3 for 16 bits works for me, so, I will not change this code in the next version. Thanks. -- Ken ar c'hentañ | ** Breizh ha Linux atav! ** Jef | http://moinejf.free.fr/