All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Giedrius Statkevicius <giedrius.statkevicius@gmail.com>
Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
	fabio.falzoi84@gmail.com
Subject: Re: [PATCH 1/5] Combine ifs into one where possible to avoid unnecessary indentation level increase
Date: Fri, 3 Oct 2014 13:34:13 -0700	[thread overview]
Message-ID: <20141003203413.GA18227@kroah.com> (raw)
In-Reply-To: <1412368028-18935-2-git-send-email-giedrius.statkevicius@gmail.com>

On Fri, Oct 03, 2014 at 11:27:04PM +0300, Giedrius Statkevicius wrote:
> From: Giedrius Statkevičius <giedrius.statkevicius@gmail.com>
> 
> Join together chained if's where possible to lower the indentation level.
> 
> Signed-off-by: Giedrius Statkevičius <giedrius.statkevicius@gmail.com>

Your subject is "odd", in that it doesn't say what part of the kernel it
is for.  Look at the kernel git logs, it should give you an idea of how
to format things properly.

Also, you don't have to have such a long subject:, try to keep it short,
and then be verbose in the changelog body.

Can you fix up all of these 5 and resend?

thanks,

greg k-h

  reply	other threads:[~2014-10-03 20:34 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-03 20:27 [PATCH 0/5] staging: rts5208: clean up coding style in rtsx_chip.c Giedrius Statkevicius
2014-10-03 20:27 ` [PATCH 1/5] Combine ifs into one where possible to avoid unnecessary indentation level increase Giedrius Statkevicius
2014-10-03 20:34   ` Greg KH [this message]
2014-10-03 20:27 ` [PATCH 2/5] Convert Camel Case labels to lower case, remove unnecessary parantheses after a dereference operator and remove empty lines before } Giedrius Statkevicius
2014-10-03 20:27 ` [PATCH 3/5] Align lines of divided lines to the opening paranthesis where possible Giedrius Statkevicius
2014-10-03 20:27 ` [PATCH 4/5] Divide lines to make them less than 80 characters long, align " Giedrius Statkevicius
2014-10-03 20:27 ` [PATCH 5/5] Use ternary operators where possible and sensible to avoid unnecessary increase of indentation level Giedrius Statkevicius

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141003203413.GA18227@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=devel@driverdev.osuosl.org \
    --cc=fabio.falzoi84@gmail.com \
    --cc=giedrius.statkevicius@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.