From: Michael Welling <mwelling@ieee.org>
To: David Miller <davem@davemloft.net>
Cc: tony@atomide.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drivers:ethernet:davinci_emac.c:Fixes flaw in mac address handling.
Date: Fri, 3 Oct 2014 15:43:59 -0500 [thread overview]
Message-ID: <20141003204359.GA10110@sysresccd> (raw)
In-Reply-To: <20141003.130305.2216770567363258603.davem@davemloft.net>
On Fri, Oct 03, 2014 at 01:03:05PM -0700, David Miller wrote:
> From: Michael Welling <mwelling@ieee.org>
> Date: Wed, 1 Oct 2014 21:32:05 -0500
>
> > The code currently checks the mac_addr variable that is clearly
> > zero'd out during allocation.
> >
> > Further code is added to bring the mac_addr from the partial pdata.
> >
> > Signed-off-by: Michael Welling <mwelling@ieee.org>
>
> I don't see anyone specifying a MAC address in the partial pdata,
> so better to just delete that field.
>
> Even if people did, I am not so sure that the partial pdata should
> unconditionally trump an OF provided MAC address.
So should I just leave the code for handling the mac_addr field from the
partial pdata out or make it such that the mac_addr field is overriden
if specified from the devicetree?
next prev parent reply other threads:[~2014-10-03 20:44 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-02 2:32 [PATCH] drivers:ethernet:davinci_emac.c:Fixes flaw in mac address handling Michael Welling
2014-10-03 20:03 ` David Miller
2014-10-03 20:43 ` Michael Welling [this message]
2014-10-03 21:55 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141003204359.GA10110@sysresccd \
--to=mwelling@ieee.org \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.