From mboxrd@z Thu Jan 1 00:00:00 1970 From: Peter Zijlstra Subject: Re: [PATCH] x86,seccomp,prctl: Remove PR_TSC_SIGSEGV and seccomp TSC filtering Date: Fri, 3 Oct 2014 23:04:28 +0200 Message-ID: <20141003210428.GH6324@worktop.programming.kicks-ass.net> References: <20141003201409.GM10583@worktop.programming.kicks-ass.net> <20141003204443.GP10583@worktop.programming.kicks-ass.net> <20141003210213.GG6324@worktop.programming.kicks-ass.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20141003210213.GG6324-IIpfhp3q70z/8w/KjCw3T+5/BudmfyzbbVWyRVo5IupeoWH0uzbU5w@public.gmane.org> Sender: linux-api-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Andy Lutomirski Cc: "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , Ingo Molnar , Kees Cook , Andrea Arcangeli , Erik Bosman , "H. Peter Anvin" , Linux API , Michael Kerrisk-manpages , Paul Mackerras , Arnaldo Carvalho de Melo , X86 ML List-Id: linux-api@vger.kernel.org On Fri, Oct 03, 2014 at 11:02:13PM +0200, Peter Zijlstra wrote: > @@ -1928,7 +1939,7 @@ void arch_perf_update_userpage(struct perf_event_mmap_page *userpg, u64 now) > > userpg->cap_user_time = 0; > userpg->cap_user_time_zero = 0; > - userpg->cap_user_rdpmc = x86_pmu.attr_rdpmc; > + userpg->cap_user_rdpmc = x86_pmu.attr_rdpmc && test_thread_flag(TIF_SECCOMP); && !test_thread_flag(TIF_SECCOMP) would probably work better > userpg->pmc_width = x86_pmu.cntval_bits; > > if (!sched_clock_stable()) From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754489AbaJCVEg (ORCPT ); Fri, 3 Oct 2014 17:04:36 -0400 Received: from bombadil.infradead.org ([198.137.202.9]:38031 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753537AbaJCVEd (ORCPT ); Fri, 3 Oct 2014 17:04:33 -0400 Date: Fri, 3 Oct 2014 23:04:28 +0200 From: Peter Zijlstra To: Andy Lutomirski Cc: "linux-kernel@vger.kernel.org" , Ingo Molnar , Kees Cook , Andrea Arcangeli , Erik Bosman , "H. Peter Anvin" , Linux API , Michael Kerrisk-manpages , Paul Mackerras , Arnaldo Carvalho de Melo , X86 ML Subject: Re: [PATCH] x86,seccomp,prctl: Remove PR_TSC_SIGSEGV and seccomp TSC filtering Message-ID: <20141003210428.GH6324@worktop.programming.kicks-ass.net> References: <20141003201409.GM10583@worktop.programming.kicks-ass.net> <20141003204443.GP10583@worktop.programming.kicks-ass.net> <20141003210213.GG6324@worktop.programming.kicks-ass.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20141003210213.GG6324@worktop.programming.kicks-ass.net> User-Agent: Mutt/1.5.22.1 (2013-10-16) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Oct 03, 2014 at 11:02:13PM +0200, Peter Zijlstra wrote: > @@ -1928,7 +1939,7 @@ void arch_perf_update_userpage(struct perf_event_mmap_page *userpg, u64 now) > > userpg->cap_user_time = 0; > userpg->cap_user_time_zero = 0; > - userpg->cap_user_rdpmc = x86_pmu.attr_rdpmc; > + userpg->cap_user_rdpmc = x86_pmu.attr_rdpmc && test_thread_flag(TIF_SECCOMP); && !test_thread_flag(TIF_SECCOMP) would probably work better > userpg->pmc_width = x86_pmu.cntval_bits; > > if (!sched_clock_stable())