All of lore.kernel.org
 help / color / mirror / Atom feed
From: Josh Triplett <josh@joshtriplett.org>
To: "Yann E. MORIN" <yann.morin.1998@free.fr>,
	"Andrew Morton" <akpm@linux-foundation.org>,
	"Eric Paris" <eparis@redhat.com>, "Michal Hocko" <mhocko@suse.cz>,
	"Matt Turner" <mattst88@gmail.com>,
	"Paul Gortmaker" <paul.gortmaker@windriver.com>,
	蔡正龙 <zhenglong.cai@cs2c.com.cn>, "Tejun Heo" <tj@kernel.org>,
	"Fabian Frederick" <fabf@skynet.be>,
	"Luis R. Rodriguez" <mcgrof@suse.com>,
	"Peter Foley" <pefoley2@pefoley.com>,
	"Konstantin Khlebnikov" <koct9i@gmail.com>,
	"Eric W. Biederman" <ebiederm@xmission.com>,
	"H. Peter Anvin" <hpa@zytor.com>,
	"Oleg Nesterov" <oleg@redhat.com>,
	linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH 1/2] init/Kconfig: Hide printk log config if CONFIG_PRINTK=n
Date: Fri, 3 Oct 2014 16:29:21 -0700	[thread overview]
Message-ID: <20141003232916.GA15905@thin> (raw)

The buffers sized by CONFIG_LOG_BUF_SHIFT and
CONFIG_LOG_CPU_MAX_BUF_SHIFT do not exist if CONFIG_PRINTK=n, so don't
ask about their size at all.

Signed-off-by: Josh Triplett <josh@joshtriplett.org>
---

Posting for review.  I can upstream this through the tiny tree.

 init/Kconfig | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/init/Kconfig b/init/Kconfig
index e84c642..31505a5 100644
--- a/init/Kconfig
+++ b/init/Kconfig
@@ -811,6 +811,7 @@ config LOG_BUF_SHIFT
 	int "Kernel log buffer size (16 => 64KB, 17 => 128KB)"
 	range 12 21
 	default 17
+	depends on PRINTK
 	help
 	  Select the minimal kernel log buffer size as a power of 2.
 	  The final size is affected by LOG_CPU_MAX_BUF_SHIFT config
@@ -830,6 +831,7 @@ config LOG_CPU_MAX_BUF_SHIFT
 	range 0 21
 	default 12 if !BASE_SMALL
 	default 0 if BASE_SMALL
+	depends on PRINTK
 	help
 	  This option allows to increase the default ring buffer size
 	  according to the number of CPUs. The value defines the contribution
-- 
2.1.1


                 reply	other threads:[~2014-10-03 23:29 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141003232916.GA15905@thin \
    --to=josh@joshtriplett.org \
    --cc=akpm@linux-foundation.org \
    --cc=ebiederm@xmission.com \
    --cc=eparis@redhat.com \
    --cc=fabf@skynet.be \
    --cc=hpa@zytor.com \
    --cc=koct9i@gmail.com \
    --cc=linux-kbuild@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mattst88@gmail.com \
    --cc=mcgrof@suse.com \
    --cc=mhocko@suse.cz \
    --cc=oleg@redhat.com \
    --cc=paul.gortmaker@windriver.com \
    --cc=pefoley2@pefoley.com \
    --cc=tj@kernel.org \
    --cc=yann.morin.1998@free.fr \
    --cc=zhenglong.cai@cs2c.com.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.