All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@infradead.org>
To: Junichi Nomura <j-nomura@ce.jp.nec.com>
Cc: Jens Axboe <axboe@kernel.dk>,
	device-mapper development <dm-devel@redhat.com>,
	Kent Overstreet <kmo@daterainc.com>,
	Mike Snitzer <snitzer@redhat.com>
Subject: Re: [PATCH 0/4] dm: reduce memory overhead of DM devices
Date: Sat, 4 Oct 2014 10:01:30 -0700	[thread overview]
Message-ID: <20141004170130.GA30207@infradead.org> (raw)
In-Reply-To: <542E8CF9.6000609@ce.jp.nec.com>

On Fri, Oct 03, 2014 at 11:48:08AM +0000, Junichi Nomura wrote:
> This series of patches reduce the memory overhead of device-mapper
> device mainly by removing unused mempool for bio vecs.
> 
> DM creates per-device bioset to ensure forward progress under
> low memory situation and bioset always includes mempool for bvec.

Thanks, this looks like a good step forward.

I'd still love to go all the way and avoid any bio cloning.  I can
see two ways to do this:

 1) similar to the original block layer multipathing with a callback
    that allows the submitter to hook into the completion path at
    blk_update_request time.
 2) by not completing the io chain in req_bio_endio, similar to how
    we do it for requests that are part of a flush sequence using
    the REQ_FLUSH_SEQ.

While the first seems like the cleaner architecture it might be worth
to look into the second version given that 1) wasn't well received
last time, and 2) already works nicely for a very similar use
case.  If we end up implementing 1) it should also be able to replace
the current flag based completion hack for the flush sequence.

      parent reply	other threads:[~2014-10-04 17:01 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-03 11:48 [PATCH 0/4] dm: reduce memory overhead of DM devices Junichi Nomura
2014-10-03 11:55 ` [PATCH 1/4] dm: remove nr_iovecs parameter from alloc_tio() Junichi Nomura
2014-10-03 20:01   ` Mike Snitzer
2014-10-03 11:55 ` [PATCH 2/4] block: use bio_clone_fast() in blk_rq_prep_clone() Junichi Nomura
2014-10-03 11:55 ` [PATCH 3/4] block: add bioset_nobvec_create() Junichi Nomura
2014-10-03 13:16   ` Mike Snitzer
2014-10-03 11:55 ` [PATCH 4/4] dm: use bioset_nobvec_create() Junichi Nomura
2014-10-03 13:23 ` [PATCH 0/4] dm: reduce memory overhead of DM devices Mike Snitzer
2014-10-03 20:48   ` Mike Snitzer
2014-10-03 20:57     ` Jens Axboe
2014-10-03 21:04       ` Mike Snitzer
2014-10-03 21:27     ` [PATCH v2 1/4] dm: remove nr_iovecs parameter from alloc_tio() Mike Snitzer
2014-10-03 21:27     ` [PATCH v2 2/4] block: use bio_clone_fast() in blk_rq_prep_clone() Mike Snitzer
2014-10-03 21:27     ` [PATCH v2 3/4] block: add bioset_create_nobvec() Mike Snitzer
2014-10-03 21:27     ` [PATCH v2 4/4] dm: use bioset_create_nobvec() Mike Snitzer
2014-10-05 23:06       ` Junichi Nomura
2014-10-06  0:24         ` Mike Snitzer
2014-10-04 17:01 ` Christoph Hellwig [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141004170130.GA30207@infradead.org \
    --to=hch@infradead.org \
    --cc=axboe@kernel.dk \
    --cc=dm-devel@redhat.com \
    --cc=j-nomura@ce.jp.nec.com \
    --cc=kmo@daterainc.com \
    --cc=snitzer@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.