From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 2/2] package/libplist: fix python support
Date: Sun, 5 Oct 2014 14:08:30 +0200 [thread overview]
Message-ID: <20141005140830.706f1b6d@free-electrons.com> (raw)
In-Reply-To: <1412502007-9902-2-git-send-email-s.martin49@gmail.com>
Dear Samuel Martin,
On Sun, 5 Oct 2014 11:40:07 +0200, Samuel Martin wrote:
> This patch:
> - fixes the python3 support detection in the libplist CMake code;
> - correctly sets the dependencies and configure options in libplist.mk.
>
> Fixes:
> http://autobuild.buildroot.net/results/efb/efba806b9a40a5e9c6bca7e591747ca2102fa1d5/
>
>
> Signed-off-by: Samuel Martin <s.martin49@gmail.com>
> ---
> ...support-python2-and-python3-when-defining.patch | 27 ++++++++++++++++++++++
> package/libplist/libplist.mk | 13 +++++++++++
> 2 files changed, 40 insertions(+)
> create mode 100644 package/libplist/libplist-0003-cmake-swig-support-python2-and-python3-when-defining.patch
Patch applied, thanks. Of course, if libplist can be bumped, it would
be good.
Another note: in this case, the Python binding requires an additional
dependency (host-swig), so I'm wondering if we shouldn't have an
explicit option to enable/disable the libplist Python binding. Right
now, as soon as you have Python and libplist enabled, you're going to
build the Python binding, which requires building host-swig, even if
you don't care at all about libplist Python binding.
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2014-10-05 12:08 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-05 9:40 [Buildroot] [PATCH 1/2] package/swig: define SWIG pointing to the host swig program Samuel Martin
2014-10-05 9:40 ` [Buildroot] [PATCH 2/2] package/libplist: fix python support Samuel Martin
2014-10-05 10:08 ` Yann E. MORIN
2014-10-05 12:08 ` Thomas Petazzoni [this message]
2014-10-05 10:09 ` [Buildroot] [PATCH 1/2] package/swig: define SWIG pointing to the host swig program Yann E. MORIN
2014-10-05 11:46 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141005140830.706f1b6d@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.